New issue
Advanced search Search tips

Issue 853766 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Metrics for Manual Filling UI

Project Member Reported by fhorschig@chromium.org, Jun 18 2018

Issue description

The following metrics could help to see if and how the keyboard accessory is used:

a) Impressions of keyboard accessory (opened for buckets: text input, password input, other)
b) Opening a bottom sheet (bucket for type of sheet: passwords, payments, etc.)
c) Closing a bottom sheet (bucket for type of sheet: passwords, payments, etc.)
d) Impressions of the automatic "Generate strong password" button
e) Clicks on the "automatic Generate strong password" button
f) Clicks on the manual "Generate strong password" button
g) Clicks on the "Show all passwords" link
h) Clicks on a credential (bucket for type of credential)
i) Number of credential pairs (0, 1, 2, 3, 4, 5, >5)

Note: a pair of impressions and clicks help to determine the click-through-rate (CTR) which helps to find out how often the feature was actually used, e.g. a&c, d&e, b&f, b&g, b&h

For dynamic content, it might be interesting to see how often users face only the default actions, e.g. many a) and b) but small number of d) or mainly bucket 0 in i).


Metrics for consideration:

j) Position of a clicked credential - is ranking important? Maybe to hide credentials if there are a lot and only the first few are actually useful.
k) UKM for etld+1 - This would show where the auto-filling stopped working. Do we have comparable metrics for Desktop?
 
Blocking: 853794

Comment 2 by nepper@chromium.org, Jun 27 2018

Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12fc413342b49f6b85206272c9fbb6e3636c0778

commit 12fc413342b49f6b85206272c9fbb6e3636c0778
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Aug 02 17:27:53 2018

[Android] Record keyboard accessory metrics

This CL introduces impression and click metrics for all actions and
suggestions and the accessory sheet in general.

Bug:  853766 
Change-Id: I47376dae669b99ae0e8701fb2e04efa292e8f673
Reviewed-on: https://chromium-review.googlesource.com/1157005
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580227}
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/base/android/junit/src/org/chromium/base/metrics/test/ShadowRecordHistogram.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/BUILD.gn
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetMediator.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[add] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/java_sources.gni
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetControllerTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/browser/BUILD.gn
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/browser/password_manager/password_accessory_controller.cc
[add] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/chrome/browser/password_manager/password_accessory_metrics_util.h
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/12fc413342b49f6b85206272c9fbb6e3636c0778/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Added all metrics from a)-i) (except f because the feature is missing).
All new metrics should be treated as new feature - this set should completely suffice for meaningful insights.

The bucketing per input-field as suggested for a) was dropped because it would rely on what we detect to be the type and therefore currently no usable.
Labels: Merge-Request-69
Merging rationale: our planned Beta experiments wouldn't be very useful without any of these metrics.

The change might be quite large but only affects code that can be turned off via Finch - should anything go wrong. The latter is unlikely as it shouldn't have changed any behavior.
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 2

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e765c364a25bad6e59a1696ce266d6b1906b32ae

commit e765c364a25bad6e59a1696ce266d6b1906b32ae
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Aug 06 08:33:11 2018

[Android] Record keyboard accessory metrics

This CL introduces impression and click metrics for all actions and
suggestions and the accessory sheet in general.

Bug:  853766 
Change-Id: I47376dae669b99ae0e8701fb2e04efa292e8f673
Reviewed-on: https://chromium-review.googlesource.com/1157005
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580227}(cherry picked from commit 12fc413342b49f6b85206272c9fbb6e3636c0778)
Reviewed-on: https://chromium-review.googlesource.com/1163383
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#409}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/base/android/junit/src/org/chromium/base/metrics/test/ShadowRecordHistogram.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/BUILD.gn
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetMediator.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[add] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/java_sources.gni
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetControllerTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/browser/BUILD.gn
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/browser/password_manager/password_accessory_controller.cc
[add] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/chrome/browser/password_manager/password_accessory_metrics_util.h
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e765c364a25bad6e59a1696ce266d6b1906b32ae/tools/metrics/histograms/histograms.xml

Sign in to add a comment