"SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/2" is flaky |
|||||||
Issue description"SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/2" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5Ub3VjaHBhZFBpbmNoT3Zlck9PUElGLzIM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 18 2018
,
Jun 18 2018
I'll disable the test; assigning to author.
,
Jun 18 2018
+ new Hit Test api devs. sunxd@ this is another /2 variant which seems to not be receiving the expected events.
,
Jun 18 2018
Note that the /1 variant is similarly flaky. Pending CL to disable: https://chromium-review.googlesource.com/c/chromium/src/+/1104657
,
Jun 18 2018
Can the new WaitForHitTestDataReady fix the problem? Otherwise we have to use loop.
,
Jun 18 2018
This test has already been updated to use the new hit testing api. Though looking at it I had to disable this on Viz as InputEventAckWaiter was never returning: issue 848348 It looks like a similar issue, no input events received, is also occurring on Windows, without Viz
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcb5a4ceb645bccb4934384ed00d9da1f373c8d0 commit bcb5a4ceb645bccb4934384ed00d9da1f373c8d0 Author: Marc Treib <treib@chromium.org> Date: Mon Jun 18 17:01:27 2018 Disable SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/1 and /2 TBR=kenrb@chromium.org Bug: 853761 Change-Id: I75eb2a580cc263a4dd4b6d3a0254fbadad8ec08e Reviewed-on: https://chromium-review.googlesource.com/1104657 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568042} [modify] https://crrev.com/bcb5a4ceb645bccb4934384ed00d9da1f373c8d0/content/browser/site_per_process_hit_test_browsertest.cc
,
Jun 18 2018
,
Jun 21 2018
Reproduced today ahead of triage
,
Jul 25
I'm going to take a look
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8976f940cfd7d12d31012f26c4d416d5b238f587 commit 8976f940cfd7d12d31012f26c4d416d5b238f587 Author: Ria Jiang <riajiang@chromium.org> Date: Thu Jul 26 19:23:09 2018 Tentatively enable some SitePerProcessHitTestBrowserTest flaky tests. RootConsumesScrollDuringOverscrollGesture, InputEventRouterTouchpadGestureTargetTest and TouchpadPinchOverOOPIF were flaky tests with Viz hit-testing config. However, looking at the log, they only happened infrequently on Android and Windows. I couldn't repro these locally and there have been some changes with how we wait for hit-test data and setting initial window bounds, so tentatively re-enable these three tests to see whether they are still flaky or not. Bug: 853761, 835058, 838835 Change-Id: I66ae6162ab9065e4a940c5779adb92254a6bf54c Reviewed-on: https://chromium-review.googlesource.com/1151899 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578398} [modify] https://crrev.com/8976f940cfd7d12d31012f26c4d416d5b238f587/content/browser/site_per_process_hit_test_browsertest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by treib@chromium.org
, Jun 18 2018