Independent from passwords stored for a given site, the accessory sheet for passwords should display a separator between the passwords section and an option linking to all passwords. (See: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZRT3KyGvNYc6/files/MCEQIFEoArGIwEvAawK07K_1wMSJbxAVNpw)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e17d393994ea54ad2af8bd0bee00706e93bbc6bd commit e17d393994ea54ad2af8bd0bee00706e93bbc6bd Author: Friedrich Horschig <fhorschig@chromium.org> Date: Fri Jun 22 12:53:04 2018 [Android] Linking from accessory sheet to passwords This CL provides the native code to the "Manage passwords..." link in the passwords accessory bottom sheet. Bug: 853747 Change-Id: I275171b1889d3ea85e3d8c3eda7feab8eed06495 Reviewed-on: https://chromium-review.googlesource.com/1110131 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569587} [modify] https://crrev.com/e17d393994ea54ad2af8bd0bee00706e93bbc6bd/chrome/app/generated_resources.grd [modify] https://crrev.com/e17d393994ea54ad2af8bd0bee00706e93bbc6bd/chrome/browser/password_manager/password_accessory_controller.cc [modify] https://crrev.com/e17d393994ea54ad2af8bd0bee00706e93bbc6bd/chrome/browser/password_manager/password_accessory_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e commit ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e Author: Friedrich Horschig <fhorschig@chromium.org> Date: Fri Jun 22 14:55:37 2018 [Android] Introduce options to password accessory This CL renders the options provided by the native backend. To do that, it introduces new |Item.Type|s. Bug: 853747 Change-Id: I6fcd833a1674d55da4e4e44d9517e3aff35da823 Reviewed-on: https://chromium-review.googlesource.com/1110217 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569624} [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/BUILD.gn [add] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/java/res/layout/password_accessory_sheet_divider.xml [add] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/java/res/layout/password_accessory_sheet_option.xml [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/browser/android/password_manager/password_accessory_view_android.cc [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/browser/android/password_manager/password_accessory_view_android.h [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/browser/password_manager/password_accessory_controller.cc [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/browser/password_manager/password_accessory_controller_unittest.cc [modify] https://crrev.com/ac8e8d3ed033d2b5dcaa5042bdb405f7ce43a83e/chrome/browser/password_manager/password_accessory_view_interface.h
Comment 1 by fhorschig@chromium.org
, Jun 18 2018