New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 853731 link

Starred by 3 users
Status: Untriaged
Owner: ----
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 823798


Sign in to add a comment

Unify Android tab ID generation (TabIdManager) with SessionID generation (SessionIdGenerator)

Project Member Reported by mastiz@chromium.org, Jun 18 2018 
TabIdManager and SessionIdGenerator seem very identical these days after SessionID-generation has recently become more sophisticated and makes session IDs unique across restarts (see crbug.com/823798).

Unifying the two would simplify the codebase in general (I'd say, minor improvement) and, in case  crbug.com/851905  gets addressed, be beneficial for sync, because no collisions would exist between session IDs and Android IDs (notable improvement).

Comment 1 by mastiz@chromium.org, Jun 18 2018

Components: Services>Sync

Comment 2 by mastiz@chromium.org, Jun 19 2018

Labels: Sync-Triaged
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b

commit 23afb1140eb738d4afa98b76c8aa0ee44ca33c3b
Author: Mikel Astiz <mastiz@chromium.org>
Date: Mon Jul 09 18:32:27 2018

Move sync code away from components/sessions

The dependency to sync is artifical and actually the code can be moved
trivially to components/sync_sessions, where it belongs.

Bug: 853731
Change-Id: I52f74b92e21f8f126fbb8a4037807b14e9eb4835
Reviewed-on: https://chromium-review.googlesource.com/1107813
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573373}
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/BUILD.gn
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/DEPS
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/core/serialized_navigation_entry.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/core/serialized_navigation_entry.h
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/core/serialized_navigation_entry_test_helper.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/core/serialized_navigation_entry_unittest.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/core/session_types.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sessions/core/session_types.h
[delete] https://crrev.com/71ac85257f083f1d3ceded06f1d66992e033d389/components/sessions/core/session_types_unittest.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/BUILD.gn
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/local_session_event_handler_impl.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/sessions_sync_manager.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/synced_session.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/synced_session.h
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/synced_session_tracker.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/synced_session_tracker.h
[add] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/synced_session_unittest.cc
[modify] https://crrev.com/23afb1140eb738d4afa98b76c8aa0ee44ca33c3b/components/sync_sessions/test_synced_window_delegates_getter.cc
►

Sign in to add a comment