New issue
Advanced search Search tips

Issue 853721 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Implement fs.readlink() on Windows

Project Member Reported by mar...@chromium.org, Jun 18 2018 
It needs to call "DeviceIoControl(h, FSCTL_GET_REPARSE_POINT, ...)". It's needed to read a symlink back, which will be needed to support symlinks on Windows correctly.

https://chromium.googlesource.com/infra/luci/luci-py.git/+/master/client/utils/fs.py
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/6b6fa798293dcc22ad6fb99087b1a3b0842baf2c

commit 6b6fa798293dcc22ad6fb99087b1a3b0842baf2c
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Jun 18 13:31:34 2018

[client] Fix regression in d335c4bf86

fs.readlink() is not yet implemented on Windows. So do not run the named cache
verification code there for now.

TBR=qyearsley@chromium.org

Bug:  717716 , 853721
Change-Id: I1de0375a5ca59e0f72bc9e68827dcaec2ccaa190
Reviewed-on: https://chromium-review.googlesource.com/1104381
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/6b6fa798293dcc22ad6fb99087b1a3b0842baf2c/client/local_caching.py
[modify] https://crrev.com/6b6fa798293dcc22ad6fb99087b1a3b0842baf2c/client/utils/fs.py

Comment 2 by mar...@chromium.org, Jun 18 2018

Labels: -Pri-3 cit-pm-86 Pri-2

Comment 3 by no...@chromium.org, Oct 2 

how would it help go/cit-pm-86? named caches use mv, not symlinks

Comment 4 by mar...@chromium.org, Oct 2 

It's more that having thorough implementation on all OSes reduces one-offs.
►

Sign in to add a comment