New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 853715 link

Starred by 3 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jun 2018
Cc:
ajha@chromium.org
tetsui@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Network settings window is seen instead of 'Join Wi-Fi network' overlay on selecting any network from Uber Tray

Project Member Reported by mmanchala@chromium.org, Jun 18 2018 
Chrome Version: 69.0.3463.0/10793.0.0  dev-channel Daisy,Reks and Candy
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen -> click on Uber Tray -> now click on 'No network' 
(2)Observe Wi-Fi is turned on -> now select any network and observe Network settings window is seen instead of 'Join Wi-Fi network' overlay and try to click on 'CONNECT and observe nothing happens i.e. Join Wi-FI overlay is not seen
(Please refer Video)

Expected:  'Join Wi-Fi network' overlay should be seen on selecting any network from Uber Tray
Actual: Instead Network settings window is seen 

This is Regression Issue as same is working fine in M-68

@stevenjb : Please confirm the Issue
Actual_NetworksettingsWindow.mp4
12.2 MB View Download
Expected_JoinWiFiOverlay.mp4
7.6 MB View Download

Comment 1 by steve...@chromium.org, Jun 18 2018

Owner: steve...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9738ab6612c60364e6dafdb8f4161ebe8110c7fb

commit 9738ab6612c60364e6dafdb8f4161ebe8110c7fb
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jun 18 21:19:06 2018

System Tray > Network: Fix secondary user logic

Checking IsUserPrimary() before login is incorrect, we need to also
check IsActiveUserSessionStarted() anywhere we want to hide or disable
UI for the secondary user.

Bug was introduced in https://chromium-review.googlesource.com/1089585

Bug:  853715 
Change-Id: Id7cb90da16e62be6f23d7df7ce499c8e4fef4786
Reviewed-on: https://chromium-review.googlesource.com/1104983
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568163}
[modify] https://crrev.com/9738ab6612c60364e6dafdb8f4161ebe8110c7fb/ash/system/network/network_list.cc
[modify] https://crrev.com/9738ab6612c60364e6dafdb8f4161ebe8110c7fb/ash/system/network/network_state_list_detailed_view.cc

Comment 3 by steve...@chromium.org, Jun 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment