New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 853713 link

Starred by 3 users
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Jun 2018
Cc:
yamaguchi@chromium.org
█ yoshiki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Tab focus is seen missing on 'Uber Tray'

Project Member Reported by mmanchala@chromium.org, Jun 18 2018 
Chrome Version: 69.0.3463.0/10793.0.0  dev-channel Daisy,Reks and Candy
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen press 'Tab' button until focus is on 'Shut down' option
(2)Now again press 'Tab' button and observe focus is seen missing on 'Uber Tray'
(Please refer Video and Screenshot)

Expected: 'Tab' focus should be seen on 'Uber Tray'
Actual: Instead 'Tab' focus is seen missing on 'Uber Tray'

This is Regression Issue as same is working fine in 69.0.3457.0/10784.0.0 dev-channel Daisy

@alemate : please confirm the Issue
Actual_NoTabFocusOnUberTray.mp4
11.7 MB View Download
Expected_TabFocusOnUberTray.mp4
8.4 MB View Download
Expected_TabFocusOnUberTray.jpg
536 KB View Download

Comment 1 by tetsui@chromium.org, Jun 19 2018

Cc: -ajha@chromium.org -tetsui@chromium.org -brajkumar@chromium.org -tbuck...@chromium.org yamaguchi@chromium.org yoshiki@chromium.org
Owner: tetsui@chromium.org

Comment 2 by tetsui@chromium.org, Jun 20 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c474b750cacded56a3164bb9cbe3619121253e7

commit 2c474b750cacded56a3164bb9cbe3619121253e7
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Jun 28 01:35:41 2018

Fix tab focusing to system tray in OOBE screen.

Recently, UnifiedSystemTray replaced SystemTray class.
WebUILoginView ignored UnifiedSystemTray because I misunderstood
views login will completely replace WebUILoginView. However,
WebUILoginView is still used in OOBE screen, so we should fix it to also
work with UnifiedSystemTray.

TEST=manual
BUG= 853713 

Change-Id: I3842eba971a928af5ba1599283c52f9711d83cc4
Reviewed-on: https://chromium-review.googlesource.com/1107520
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570996}
[modify] https://crrev.com/2c474b750cacded56a3164bb9cbe3619121253e7/ash/root_window_controller.cc
[modify] https://crrev.com/2c474b750cacded56a3164bb9cbe3619121253e7/ash/root_window_controller.h
[modify] https://crrev.com/2c474b750cacded56a3164bb9cbe3619121253e7/chrome/browser/chromeos/login/ui/webui_login_view.cc

Comment 4 by tetsui@chromium.org, Jun 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment