Issue metadata
Sign in to add a comment
|
0.2% regression in sizes at 567307:567307 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 18 2018
Assigning to cblume@chromium.org because this is the only CL in range: Enable Vulkan support by default Currently, building with Vulkan support is behind a gn flag (enable_vulkan). It would be easy to not build & test with this flag. As a result, it would also be easy to allow Vulkan support to bitrot. Enabling Vulkan building by default would keep the Vulkan code buildable. This patch does that. (You still need a command line parameter of --enable-vulkan when running Chrome to actually use the Vulkan codepath. This is just for the building.) BUG= 848100 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I26fa03f9f6e2dc924691db913f723661b510f272 Reviewed-on: https://chromium-review.googlesource.com/1098117 Reviewed-by: Brian Salomon <bsalomon@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#567307}
,
Jun 18 2018
This is likely an intended growth by adding bunch of files. cblume: If 300kB growth looks reasonable to you for the vulkan support, just close this as WontFix.
,
Jun 18 2018
300 KiB of binary size growth is more than I would have guessed. But it doesn't sound unreasonable. There are many codepaths which are now available behind a run-time flag. I think this is okay.
,
Aug 22
I had previously marked this as Wont Fix. But I'm now investigating if there is a way to reduce binary size. Duplicating into the bug where that investigation is happening. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 18 2018