Issue metadata
Sign in to add a comment
|
Regression: Focus ring on 'View site info' icon is overlapped with vertical line.
Reported by
db...@etouch.net,
Jun 18 2018
|
||||||||||||||||||||||||
Issue descriptionChrome Version : 69.0.3464.0 (Official Build)Revision 3c26b60e3842fee660bcff5eb35aa0587d795f02-refs/branch-heads/3464@{#1} (64 bit) OS: Mac (10.12.6, 10.13.1, 10.13.5, 10.13.6) Pre-condition: Enable "Use Views browser windows instead of Cocoa." flag in chrome://flags What steps will reproduce the problem? (1) Launch chrome,navigate to chrome://version page and press Tab key. (2) Observe focus ring on View site info icon. Actual: Focus ring is overlapped with vertical line. Expected: Focus ring should not overlap with vertical line. This is Regression issue broken in 'M-69' and providing the bisect info below: Good Build: 69.0.3452.0 (Revision: 565144) Bad Build: 69.0.3453.0 (Revision: 565531) You are probably looking for a change made after 565672 (known good), but no later than 565673 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/da5bdd0447bb19040c26dfc86debd36955ab98d3..8f2f9568808ee117698e0a9008a0b52902d2363e Suspect: https://chromium.googlesource.com/chromium/src/+/8f2f9568808ee117698e0a9008a0b52902d2363e @erikchen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is not seen on Windows (7, 8, 8.1, 10) & Linux (14.04 LTS) OS. Kindly refer attached screen-cast. Thank You..!!
,
Jun 18 2018
I cannot repro this problem. Pressing tab never cycles to the view site info button. Am I doing something wrong? Regardless, this sounds like a focus issue. Over to lgrey@ has ellyjones@ stand-in.
,
Jun 18 2018
erikchen@ you would need to have full keyboard access on
,
Jun 18 2018
We should probably remove the separator on focus, the way it's currently removed on hover.
,
Aug 28
Can't repro this anymore, think it got fixed by Desktop UI team a while back |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Jun 18 2018