Issue metadata
Sign in to add a comment
|
0.3%-0.9% regression in sizes at 567972:567972 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 18 2018
Assigning to tkent@chromium.org because this is the only CL in range: Oilpan: Reduce the size of heap_page.h. heap_page.h is used in 6,000+ compilation units, and this CL reduces its estimated expanded size from 1.72MB to 1.40MB. Bug: 242216 Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a Reviewed-on: https://chromium-review.googlesource.com/1104080 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#567972}
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d commit 2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d Author: Taiju Tsuiki <tzik@chromium.org> Date: Mon Jun 18 12:23:36 2018 Revert "Oilpan: Reduce the size of heap_page.h." This reverts commit c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3. Reason for revert: This seems to gain the binary size by 0.3~0.9% on mac and win. Original change's description: > Oilpan: Reduce the size of heap_page.h. > > heap_page.h is used in 6,000+ compilation units, and this CL reduces its > estimated expanded size from 1.72MB to 1.40MB. > > Bug: 242216 > Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a > Reviewed-on: https://chromium-review.googlesource.com/1104080 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567972} TBR=keishi@chromium.org,tkent@chromium.org Change-Id: I54c95f8102aadf8459a833db0d27b970d291eb93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 242216, 853703 Reviewed-on: https://chromium-review.googlesource.com/1104357 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#567981} [modify] https://crrev.com/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d/third_party/blink/renderer/platform/heap/heap_page.cc [modify] https://crrev.com/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d/third_party/blink/renderer/platform/heap/heap_page.h
,
Jun 19 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 18 2018