New issue
Advanced search Search tips

Issue 853703 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.3%-0.9% regression in sizes at 567972:567972

Project Member Reported by tzik@chromium.org, Jun 18 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jun 18 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=853703

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=90af9614d17fb24bd6ee190e46de9431ddc795e44d1fa522e0b6a35ba6171e7e


Bot(s) for this bug's original alert(s):

mac
win
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 18 2018

Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Assigning to tkent@chromium.org because this is the only CL in range:
Oilpan: Reduce the size of heap_page.h.

heap_page.h is used in 6,000+ compilation units, and this CL reduces its
estimated expanded size from 1.72MB to 1.40MB.

Bug: 242216
Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a
Reviewed-on: https://chromium-review.googlesource.com/1104080
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567972}
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d

commit 2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d
Author: Taiju Tsuiki <tzik@chromium.org>
Date: Mon Jun 18 12:23:36 2018

Revert "Oilpan: Reduce the size of heap_page.h."

This reverts commit c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3.

Reason for revert:
This seems to gain the binary size by 0.3~0.9% on mac and win.

Original change's description:
> Oilpan: Reduce the size of heap_page.h.
> 
> heap_page.h is used in 6,000+ compilation units, and this CL reduces its
> estimated expanded size from 1.72MB to 1.40MB.
> 
> Bug: 242216
> Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a
> Reviewed-on: https://chromium-review.googlesource.com/1104080
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567972}

TBR=keishi@chromium.org,tkent@chromium.org

Change-Id: I54c95f8102aadf8459a833db0d27b970d291eb93
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 242216,  853703 
Reviewed-on: https://chromium-review.googlesource.com/1104357
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567981}
[modify] https://crrev.com/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d/third_party/blink/renderer/platform/heap/heap_page.cc
[modify] https://crrev.com/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d/third_party/blink/renderer/platform/heap/heap_page.h

Comment 4 by tkent@chromium.org, Jun 19 2018

Components: Blink>MemoryAllocator>GarbageCollection
Status: Fixed (was: Assigned)

Sign in to add a comment