New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853699 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

AEC3: Noisy nearend spectrum estimates

Project Member Reported by gustaf@chromium.org, Jun 18 2018

Issue description

The estimate of the nearend spectrum used in the suppressor is based on just 4 ms of audio data which makes it noisy. Using a larger time window might stabilize the suppressor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8406c4379561ff8c731ce604f5fa9384a00f3e94

commit 8406c4379561ff8c731ce604f5fa9384a00f3e94
Author: Gustaf Ullberg <gustaf@webrtc.org>
Date: Tue Jun 19 11:50:30 2018

AEC3: Average the spectrum of multiple nearend frames in the suppressor.

Reduce noise of the nearend spectrum estimation by averaging multiple
frames.

Bug:  webrtc:9420 , chromium:853699 
Change-Id: Iad7e68b1209a369e263b2d892791943e42bfbb3f
Reviewed-on: https://webrtc-review.googlesource.com/83960
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23655}
[modify] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/modules/audio_processing/aec3/echo_canceller3.cc
[add] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/modules/audio_processing/aec3/moving_average.cc
[add] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/modules/audio_processing/aec3/moving_average.h
[modify] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/modules/audio_processing/aec3/suppression_gain.cc
[modify] https://crrev.com/8406c4379561ff8c731ce604f5fa9384a00f3e94/modules/audio_processing/aec3/suppression_gain.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/bbfcc703ad1b5ae141dcd9c6a951241f6fc03967

commit bbfcc703ad1b5ae141dcd9c6a951241f6fc03967
Author: Gustaf Ullberg <gustaf@webrtc.org>
Date: Tue Jun 19 12:45:10 2018

AEC3: Unittests for MovingAverage

Bug:  webrtc:9420 , chromium:853699 
Change-Id: Ibeeca826bb35f0efa245f0dea1a567823ee80cc7
Reviewed-on: https://webrtc-review.googlesource.com/84124
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23658}
[modify] https://crrev.com/bbfcc703ad1b5ae141dcd9c6a951241f6fc03967/modules/audio_processing/aec3/BUILD.gn
[add] https://crrev.com/bbfcc703ad1b5ae141dcd9c6a951241f6fc03967/modules/audio_processing/aec3/moving_average_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56be636374195e020d6e0dfb50ba383b320d60f9

commit 56be636374195e020d6e0dfb50ba383b320d60f9
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jun 20 01:18:30 2018

Roll src/third_party/webrtc 790da37b72f9..66cadcc6b924 (19 commits)

https://webrtc.googlesource.com/src.git/+log/790da37b72f9..66cadcc6b924


git log 790da37b72f9..66cadcc6b924 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 danilchap@webrtc.org Replace rtc::Optional with absl::optional in pc
2018-06-19 buildbot@webrtc.org Roll chromium_revision c27ef6f9f6..6e14efc13e (568443:568572)
2018-06-19 deadbeef@webrtc.org Return SSRC stats with the old stats API when SSRCs are unsignaled.
2018-06-19 philipel@webrtc.org Clean up in module_common_types.h by removing the unused struct RTPAudioHeader.
2018-06-19 nisse@webrtc.org Add setter method EncodedFrame::SetTimestamp.
2018-06-19 buildbot@webrtc.org Roll chromium_revision 9d565db4c0..c27ef6f9f6 (568343:568443)
2018-06-19 phensman@webrtc.org Add separate native library for instrumentationtests
2018-06-19 danilchap@webrtc.org Add Parsing/Building generic frame descriptor extension
2018-06-19 nisse@webrtc.org Add nisse@ as owner of api/video/
2018-06-19 yvesg@webrtc.org Reformat the WebRTC code base
2018-06-19 danilchap@webrtc.org Replace rtc::Optional with absl::optional in modules/audio_coding
2018-06-19 gustaf@webrtc.org AEC3: Unittests for MovingAverage
2018-06-19 nisse@webrtc.org Drop tools/gyp from dependencies
2018-06-19 aleloi@webrtc.org Cover AecDump calls in APM fuzzer.
2018-06-19 gustaf@webrtc.org AEC3: Average the spectrum of multiple nearend frames in the suppressor.
2018-06-19 nisse@webrtc.org Delete picture id and tl0 index from CodecSpecificInfo.
2018-06-19 danilchap@webrtc.org Replace rtc::Optional with absl::optional in modules/audio processing
2018-06-19 magjed@webrtc.org Android: Simlify createOesTextureBuffer() in VideoFrameBufferTest
2018-06-19 aleloi@webrtc.org Always enable 'delay-agnostic' in APM fuzzer.


Created with:
  gclient setdep -r src/third_party/webrtc@66cadcc6b924

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:none,chromium:None,chromium:None,chromium:853699,chromium:853699,chromium:824638 webrtc:9423
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0aa4269fd97a57bb9c4e5e326670ff92848c8d82
Reviewed-on: https://chromium-review.googlesource.com/1107178
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568679}
[modify] https://crrev.com/56be636374195e020d6e0dfb50ba383b320d60f9/DEPS

Is this finished?
Status: Fixed (was: Started)

Sign in to add a comment