New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853695 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression: In High contrast mode, disabled options are not seen in grey color in Ubertray menu

Project Member Reported by kebalaji@chromium.org, Jun 18 2018

Issue description

Chrome Version: 69.0.3463.0/10793.0.0  dev-channel Daisy, Candy and Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Enable High contrast mode>> Click on Ubertray and observe

Actual: Disabled options are not seen greyed out
Expected: Disabled options should be seen in grey color

This is a Regression issue as same is working fine in 69.0.3457.0/10784.0.0 dev

 
ActualHC.mp4
3.9 MB View Download
ExpectedHC.mp4
2.8 MB View Download

Comment 1 by tetsui@chromium.org, Jun 19 2018

Cc: -ajha@chromium.org -tetsui@chromium.org -brajkumar@chromium.org yamaguchi@chromium.org yoshiki@chromium.org sgabr...@chromium.org
Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)
Cc: -yamaguchi@chromium.org tetsui@chromium.org
Owner: yamaguchi@chromium.org
Status: WontFix (was: Assigned)
Please retry with the latest build.
After Issue 864233 fixed, disabled buttons will no longer be shown in the shortcut buttons row at the top of the uber tray.
Let us know if similar issue is seen in any other places.
Status: Assigned (was: WontFix)
Issue is reproducible on 70.0.3519.3/10964.0.0 dev channel Daisy,Reks,Candy,Blaze. 

Steps to reproduce:
-----------------
1. Recover build>> Enable High contrast mode
2. Click on Ubertray and then on Accessibility and observe the disabled buttons. They are not seen greyed out. 

Thanks!
Cc: yamaguchi@chromium.org
Owner: kebalaji@chromium.org
I tried the same version (70.0.3519.3/10964.0.0). Although it's on a different device (kevin), I could not see the originally reported issue. So I am suspecting it is different on your devices.

Which are the "Disabled options" you meant? Please designate which exact buttons needs to be grayed out using a screenshot.

Based on the screencast movie in the first report, I made guess it's the buttons at the top row (lock, settings, and power). To be clear, with our recent change we made changed to remove the disabled buttons there (lock and settings are gone, only leaving the power button).
20180813_221820.jpg
219 KB View Download
Owner: yamaguchi@chromium.org
C#5-->
Which are the "Disabled options" you meant? Please designate which exact buttons needs to be grayed out using a screenshot.
>>Please refer to the below attached file. I am referring to the Help and Settings icon




Help&Settings.jpg
1.9 MB View Download
tetsui@, considering the consistency with other places, should we hide these buttons as well rather than graying out?
Owner: sgabr...@chromium.org
From the screenshot #6, I could see that it is a question of the color scheme.

- The buttons are actually grayed out but potentially difficult to recognize it depending on some conditions like the display gamma, background, etc.
- Also, it might not be intuitive if an icon is grayed out or not when there's no enabled icon nearby.
- We can see both enabled and disabled buttons in the Network menu during OOBE. See attached image.

Assigning to sgabriel@ to see if we need to change this.
top-shortcut-buttons-in-network.png
4.9 KB View Download
Quick check on the colors.
What are we using for both variants?

When on black, the icons should be Grey 700 #5F6368
When on white, ths icons should be Grey 300 #DADCE0

Or are we using opacity?
Owner: yamaguchi@chromium.org
Status: Started (was: Assigned)
The color of the disabled button icons is RGBA=(F1, F3, F4, A3) with current code, but will change.
We've found icon colors has been different from the spec. Also there seems to be a confusion between "disabled" with "inactive" icons. We'll fix them. crrev.com/c/1180787 crrev.com/c/1181015
Here is the screenshot after the planned changes in #10.
disabled_icon_sample_unified.png
5.1 KB View Download
The changes in #10 will also affect for --disable-features=SystemTrayUnified.
If we were to patch the changes to M69, it'd look like this.
disabled_icon_sample_old_tray.png
5.5 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/847cde68d187bdb50046fd1c7e0153d87e568b1d

commit 847cde68d187bdb50046fd1c7e0153d87e568b1d
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Aug 22 13:18:45 2018

Change disabled icon and label colors to be fitted to the spec.

The color of disabled icons are different from the inactive ones.
Disabled means the function is not available, whereas inactive means
the toggle state is turned to OFF.

Bug:  853695 ,875459
Change-Id: I0f4115483f5477720e65b7a0d25c7f5f79a184e5
Reviewed-on: https://chromium-review.googlesource.com/1181015
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584993}
[modify] https://crrev.com/847cde68d187bdb50046fd1c7e0153d87e568b1d/ash/system/tray/tray_constants.h

Labels: Merge-Request-69
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 22

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79f30e3f2a4a7ee5f776f6598f619ae5e816f91

commit a79f30e3f2a4a7ee5f776f6598f619ae5e816f91
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Aug 23 01:57:46 2018

Unified: Change tray icon color to be fitted to the spec.

The color of active icons should be Grey 200, which is darker than the
labels by 1 level.
This will affect multiple places including:
- tray collapse button
- feature pod icons
- top shortcut buttons
- slider button
- menu back arrow icon
- ink drop of sign out button
- tray popup

Bug:  853695 
Change-Id: Ifbbfe221db040f2f02d9577a636b7c7dd4f796f0
Reviewed-on: https://chromium-review.googlesource.com/1180787
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585363}
[modify] https://crrev.com/a79f30e3f2a4a7ee5f776f6598f619ae5e816f91/ash/system/tray/tray_constants.h

https://chromium-review.googlesource.com/1181015 is the change to be cherrypicked for this bug.
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 24

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf75db92062a84840ab9f89eeaa479affdc12175

commit cf75db92062a84840ab9f89eeaa479affdc12175
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Aug 24 03:33:03 2018

Change disabled icon and label colors to be fitted to the spec.

The color of disabled icons are different from the inactive ones.
Disabled means the function is not available, whereas inactive means
the toggle state is turned to OFF.

TBR=yamaguchi@chromium.org

(cherry picked from commit 847cde68d187bdb50046fd1c7e0153d87e568b1d)

Bug:  853695 ,875459
Change-Id: I0f4115483f5477720e65b7a0d25c7f5f79a184e5
Reviewed-on: https://chromium-review.googlesource.com/1181015
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584993}
Reviewed-on: https://chromium-review.googlesource.com/1187846
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#797}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/cf75db92062a84840ab9f89eeaa479affdc12175/ash/system/tray/tray_constants.h

Status: Fixed (was: Started)
To be verified on M69.

Sign in to add a comment