Issue metadata
Sign in to add a comment
|
Regression: In High contrast mode, disabled options are not seen in grey color in Ubertray menu |
||||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3463.0/10793.0.0 dev-channel Daisy, Candy and Reks OS: Chrome OS What steps will reproduce the problem? (1)Recover build>> Enable High contrast mode>> Click on Ubertray and observe Actual: Disabled options are not seen greyed out Expected: Disabled options should be seen in grey color This is a Regression issue as same is working fine in 69.0.3457.0/10784.0.0 dev
,
Aug 7
,
Aug 7
Please retry with the latest build. After Issue 864233 fixed, disabled buttons will no longer be shown in the shortcut buttons row at the top of the uber tray. Let us know if similar issue is seen in any other places.
,
Aug 13
Issue is reproducible on 70.0.3519.3/10964.0.0 dev channel Daisy,Reks,Candy,Blaze. Steps to reproduce: ----------------- 1. Recover build>> Enable High contrast mode 2. Click on Ubertray and then on Accessibility and observe the disabled buttons. They are not seen greyed out. Thanks!
,
Aug 13
I tried the same version (70.0.3519.3/10964.0.0). Although it's on a different device (kevin), I could not see the originally reported issue. So I am suspecting it is different on your devices. Which are the "Disabled options" you meant? Please designate which exact buttons needs to be grayed out using a screenshot. Based on the screencast movie in the first report, I made guess it's the buttons at the top row (lock, settings, and power). To be clear, with our recent change we made changed to remove the disabled buttons there (lock and settings are gone, only leaving the power button).
,
Aug 16
C#5--> Which are the "Disabled options" you meant? Please designate which exact buttons needs to be grayed out using a screenshot. >>Please refer to the below attached file. I am referring to the Help and Settings icon
,
Aug 17
tetsui@, considering the consistency with other places, should we hide these buttons as well rather than graying out?
,
Aug 17
From the screenshot #6, I could see that it is a question of the color scheme. - The buttons are actually grayed out but potentially difficult to recognize it depending on some conditions like the display gamma, background, etc. - Also, it might not be intuitive if an icon is grayed out or not when there's no enabled icon nearby. - We can see both enabled and disabled buttons in the Network menu during OOBE. See attached image. Assigning to sgabriel@ to see if we need to change this.
,
Aug 17
Quick check on the colors. What are we using for both variants? When on black, the icons should be Grey 700 #5F6368 When on white, ths icons should be Grey 300 #DADCE0 Or are we using opacity?
,
Aug 20
The color of the disabled button icons is RGBA=(F1, F3, F4, A3) with current code, but will change. We've found icon colors has been different from the spec. Also there seems to be a confusion between "disabled" with "inactive" icons. We'll fix them. crrev.com/c/1180787 crrev.com/c/1181015
,
Aug 20
Here is the screenshot after the planned changes in #10.
,
Aug 20
The changes in #10 will also affect for --disable-features=SystemTrayUnified. If we were to patch the changes to M69, it'd look like this.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/847cde68d187bdb50046fd1c7e0153d87e568b1d commit 847cde68d187bdb50046fd1c7e0153d87e568b1d Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Aug 22 13:18:45 2018 Change disabled icon and label colors to be fitted to the spec. The color of disabled icons are different from the inactive ones. Disabled means the function is not available, whereas inactive means the toggle state is turned to OFF. Bug: 853695 ,875459 Change-Id: I0f4115483f5477720e65b7a0d25c7f5f79a184e5 Reviewed-on: https://chromium-review.googlesource.com/1181015 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584993} [modify] https://crrev.com/847cde68d187bdb50046fd1c7e0153d87e568b1d/ash/system/tray/tray_constants.h
,
Aug 22
,
Aug 22
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a79f30e3f2a4a7ee5f776f6598f619ae5e816f91 commit a79f30e3f2a4a7ee5f776f6598f619ae5e816f91 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Aug 23 01:57:46 2018 Unified: Change tray icon color to be fitted to the spec. The color of active icons should be Grey 200, which is darker than the labels by 1 level. This will affect multiple places including: - tray collapse button - feature pod icons - top shortcut buttons - slider button - menu back arrow icon - ink drop of sign out button - tray popup Bug: 853695 Change-Id: Ifbbfe221db040f2f02d9577a636b7c7dd4f796f0 Reviewed-on: https://chromium-review.googlesource.com/1180787 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585363} [modify] https://crrev.com/a79f30e3f2a4a7ee5f776f6598f619ae5e816f91/ash/system/tray/tray_constants.h
,
Aug 23
https://chromium-review.googlesource.com/1181015 is the change to be cherrypicked for this bug.
,
Aug 23
Merge approved, M69.
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf75db92062a84840ab9f89eeaa479affdc12175 commit cf75db92062a84840ab9f89eeaa479affdc12175 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Aug 24 03:33:03 2018 Change disabled icon and label colors to be fitted to the spec. The color of disabled icons are different from the inactive ones. Disabled means the function is not available, whereas inactive means the toggle state is turned to OFF. TBR=yamaguchi@chromium.org (cherry picked from commit 847cde68d187bdb50046fd1c7e0153d87e568b1d) Bug: 853695 ,875459 Change-Id: I0f4115483f5477720e65b7a0d25c7f5f79a184e5 Reviewed-on: https://chromium-review.googlesource.com/1181015 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#584993} Reviewed-on: https://chromium-review.googlesource.com/1187846 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#797} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/cf75db92062a84840ab9f89eeaa479affdc12175/ash/system/tray/tray_constants.h
,
Aug 27
To be verified on M69. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Jun 19 2018Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)