Tracking bug for design/implementation changes needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ea3388bb33c6c278ac0e33265d96ee4984be9c commit f7ea3388bb33c6c278ac0e33265d96ee4984be9c Author: Mikel Astiz <mastiz@chromium.org> Date: Tue Jul 24 16:19:17 2018 Introduce skeleton code for Wallet USS implementation No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletSyncableService. Bug: 853688 Change-Id: Ia0963fbad2d3e046686e93aea6468283bad186fd Reviewed-on: https://chromium-review.googlesource.com/1147223 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577570} [modify] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/autofill/core/browser/BUILD.gn [add] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/autofill/core/browser/webdata/OWNERS [add] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [add] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [modify] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/browser_sync/profile_sync_components_factory_impl.cc [modify] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/sync/driver/sync_driver_switches.h [modify] https://crrev.com/f7ea3388bb33c6c278ac0e33265d96ee4984be9c/components/webdata_services/web_data_service_wrapper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1fc5fc543d96b6174f2948c2ca4efe8d67ac12d commit c1fc5fc543d96b6174f2948c2ca4efe8d67ac12d Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Jul 24 18:23:21 2018 [Autofill sync] Make //components/sync/OWNERS own autofill sync bridges This CL makes all sync owners own autofill sync bridges. The current owner from the sync team (jkrcal@) is left there to indicate who is the primary POC for this code. Bug: 853688 Change-Id: I0a5d26ccbbd75b86033b853e37fc29a1998050ea Reviewed-on: https://chromium-review.googlesource.com/1148578 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577615} [modify] https://crrev.com/c1fc5fc543d96b6174f2948c2ca4efe8d67ac12d/components/autofill/core/browser/webdata/OWNERS
Given that this tracks both the metadata and data migration I think it makes sense to have Jan as owner :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7873f4748ddb4941cde91e27a007ec8efde94130 commit 7873f4748ddb4941cde91e27a007ec8efde94130 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jul 25 14:13:44 2018 [Autofill wallet] Introduce skeleton code for metadata sync for USS No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletMetadataSyncableService. This CL fixes a few omissions from an analogous CL 1147223: - ios specific code for getting the controller delegate, - getting the delegate in ProfileSyncComponentsFactoryImpl. Bug: 853688 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibfef1455df0d1a94aa56d34a8c838a9ac43fa5f4 Reviewed-on: https://chromium-review.googlesource.com/1148575 Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577872} [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/autofill/core/browser/BUILD.gn [add] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [add] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/browser_sync/profile_sync_components_factory_impl.cc [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/sync/driver/sync_driver_switches.h [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/components/webdata_services/web_data_service_wrapper.cc [modify] https://crrev.com/7873f4748ddb4941cde91e27a007ec8efde94130/ios/chrome/browser/sync/ios_chrome_sync_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0365d00eadee5c3b30271e36f95fceecc6634c31 commit 0365d00eadee5c3b30271e36f95fceecc6634c31 Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Jul 26 06:34:55 2018 [Autofill wallet] Implement storage keys and client tags for metadata This CL implements GetStorageKey() and GetClientTag() functions of the wallet_metadata USS bridge. The implementation is compatible with the previous syncable service code. Bug: 853688 Change-Id: Iafcb631481ccdfa832648a66bb73e1b65b95d524 Reviewed-on: https://chromium-review.googlesource.com/1150155 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578220} [modify] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [add] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6314e2f7692ab699eda8209cb106edb615b39bc8 commit 6314e2f7692ab699eda8209cb106edb615b39bc8 Author: sebsg <sebsg@chromium.org> Date: Thu Jul 26 14:52:22 2018 [AF wallet] Implement storage keys and client tags for wallet data. This CL implements GetStorageKey() and GetClientTag() functions of the autofill wallet USS bridge. The implementation is compatible with the previous syncable service code. Bug: 853688 Change-Id: If86916ef6486b104685e615c68010ac9da281b61 Reviewed-on: https://chromium-review.googlesource.com/1148962 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#578302} [modify] https://crrev.com/6314e2f7692ab699eda8209cb106edb615b39bc8/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/6314e2f7692ab699eda8209cb106edb615b39bc8/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/6314e2f7692ab699eda8209cb106edb615b39bc8/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [add] https://crrev.com/6314e2f7692ab699eda8209cb106edb615b39bc8/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcb7db78edc13f57577f0a9562c98918bdcc10ae commit bcb7db78edc13f57577f0a9562c98918bdcc10ae Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Jul 26 16:26:34 2018 [Autofill wallet metadata] Implement GetData() in the USS bridge This CL implements the functions to load the data of the model type. In particular, the function GetAllDataForDebugging() unblocks writing unit-tests for further changes. Bug: 853688 Change-Id: I6705ed3fd76b83fc59538c2d9e5b4f4a12b57436 Reviewed-on: https://chromium-review.googlesource.com/1151298 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578333} [modify] https://crrev.com/bcb7db78edc13f57577f0a9562c98918bdcc10ae/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/bcb7db78edc13f57577f0a9562c98918bdcc10ae/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h [modify] https://crrev.com/bcb7db78edc13f57577f0a9562c98918bdcc10ae/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d85e92e5743b4b5e11192699b15eaa1985e6e9cd commit d85e92e5743b4b5e11192699b15eaa1985e6e9cd Author: sebsg <sebsg@chromium.org> Date: Mon Aug 06 16:53:53 2018 [AF USS] Implement GetAllDataForDebugging for the wallet data bridge. Bug: 853688 Change-Id: Ibac26f2adab7a360d866e3abc75b36f0bab8ab51 Reviewed-on: https://chromium-review.googlesource.com/1152085 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#580896} [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/BUILD.gn [add] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_sync_bridge_test_util.cc [add] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_sync_bridge_test_util.h [add] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [add] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [modify] https://crrev.com/d85e92e5743b4b5e11192699b15eaa1985e6e9cd/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b02e3f5ea2c17df05489c92da37e5521b074283 commit 4b02e3f5ea2c17df05489c92da37e5521b074283 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Aug 07 09:38:22 2018 [Autofill wallet] Implement local changes for metadata sync This CL implements the following features in the wallet_metadata USS sync bridge: - caching current sync data and filling the cache on start, - informing the processor the bridge is ready to sync, - reacting to local single modifications of server profiles and cards (i.e. to updating the use stats when the address/card is used). Bug: 853688 Change-Id: I07405e02cdf9cd0eb814179d883594253859845c Reviewed-on: https://chromium-review.googlesource.com/1151628 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581183} [modify] https://crrev.com/4b02e3f5ea2c17df05489c92da37e5521b074283/components/autofill/core/browser/webdata/autofill_table.cc [modify] https://crrev.com/4b02e3f5ea2c17df05489c92da37e5521b074283/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/4b02e3f5ea2c17df05489c92da37e5521b074283/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h [modify] https://crrev.com/4b02e3f5ea2c17df05489c92da37e5521b074283/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6 commit c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6 Author: sebsg <sebsg@chromium.org> Date: Wed Aug 08 22:56:03 2018 [AF USS] Implement AutofillWalletSyncBridge::ApplySyncChanges Bug: 853688 Change-Id: Ifa83c61a4bf2865379e27945bd1dc7eba1e74fc8 Reviewed-on: https://chromium-review.googlesource.com/1164162 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#581713} [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/autofill_test_utils.cc [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/autofill_test_utils.h [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_sync_bridge_test_util.cc [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_sync_bridge_test_util.h [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [add] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_sync_bridge_util_unittest.cc [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_table.cc [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [modify] https://crrev.com/c6fe6160ddd0e0b1f575e1b0649a95a7cb180de6/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3641b9174dc70ad2ead9c2577ae97739674a1be commit e3641b9174dc70ad2ead9c2577ae97739674a1be Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Aug 10 17:53:31 2018 [AF] Add chrome://flags entry for enabling USS for wallet data Bug: 853688 Change-Id: I4069581ed4eea46c04351593a595102783bac438 Reviewed-on: https://chromium-review.googlesource.com/1169479 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582237} [modify] https://crrev.com/e3641b9174dc70ad2ead9c2577ae97739674a1be/chrome/browser/about_flags.cc [modify] https://crrev.com/e3641b9174dc70ad2ead9c2577ae97739674a1be/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/e3641b9174dc70ad2ead9c2577ae97739674a1be/chrome/browser/flag_descriptions.h [modify] https://crrev.com/e3641b9174dc70ad2ead9c2577ae97739674a1be/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9a6dc3290dcacd28879693c4c111c3f6b4636f0 commit f9a6dc3290dcacd28879693c4c111c3f6b4636f0 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Aug 29 10:35:03 2018 [AF Wallet] Create an integration test for empty updates This CL adds a test for the common scenario that the sync server sends an empty update for the wallet data model type. This should have no impact on local data. Bug: 853688 Change-Id: Ib9699c0c0f531c0608f470ab59111da68253e3c2 Reviewed-on: https://chromium-review.googlesource.com/1193885 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#587063} [modify] https://crrev.com/f9a6dc3290dcacd28879693c4c111c3f6b4636f0/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7544fa319794b67426d6c9872e2f8fdc9f69c40 commit a7544fa319794b67426d6c9872e2f8fdc9f69c40 Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Sep 20 12:33:38 2018 [AF] Reduce no of AutofillWebDataBackend test implementations This CL makes a cleanup in autofill sync unit-test, reducing code duplication and getting rid of custom fakes that can be mocked in one line. It also renames another existing fake to achieve more consistency in naming (w.r.t. gmock). This CL precedes a change in the AutofillWebDataBackend interface, making it easier to implement. Bug: 853688 Change-Id: Iaf9ec6151caa77e9b81297f50c061835443cfadd Reviewed-on: https://chromium-review.googlesource.com/1235716 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592771} [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/autofill_profile_sync_bridge_unittest.cc [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc [add] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/mock_autofill_webdata_backend.cc [add] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/autofill/core/browser/webdata/mock_autofill_webdata_backend.h [modify] https://crrev.com/a7544fa319794b67426d6c9872e2f8fdc9f69c40/components/browser_sync/profile_sync_service_autofill_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f4f3ac567ed9797b4456ba8d1f4a10844d759e1 commit 4f4f3ac567ed9797b4456ba8d1f4a10844d759e1 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Sep 21 08:22:09 2018 [AF Wallet] Test histograms for the wallet data bridge This CL adds histogram checks into unit-tests for the autofill wallet data bridge. Apart from verifying we send correct metrics, this also checks that we write to DB only when needed. Since this was previously untested, this new check revealed a minor typo in one of the tests. This CL also prepares ground for a follow-up CL that refines wallet data notifications (i.e. makes the information previously only revealed to metrics also available to observers). Bug: 853688 Change-Id: Ia17d54ff81f1d04316c10d6ef548b20e3d8a9905 Reviewed-on: https://chromium-review.googlesource.com/1236275 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593115} [modify] https://crrev.com/4f4f3ac567ed9797b4456ba8d1f4a10844d759e1/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cde533a2aa66ce8ba7a41d4b09c0569e696f23c2 commit cde533a2aa66ce8ba7a41d4b09c0569e696f23c2 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Sep 21 13:14:28 2018 [AF Wallet] Use different specifics ids in integration tests This CL fixes an omission in integration tests for autofill wallet that different credit cards / addresses served by the server still had same ids in the specifics. This in particular fixes a test failure for CL 1236693. Bug: 853688 Change-Id: Iecb050ceb56f709004b16f6712196b71d0be56b0 Reviewed-on: https://chromium-review.googlesource.com/1238536 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593161} [modify] https://crrev.com/cde533a2aa66ce8ba7a41d4b09c0569e696f23c2/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/265dbbbd831a280c4142f40b20dee2f82fd84649 commit 265dbbbd831a280c4142f40b20dee2f82fd84649 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Sep 21 15:03:59 2018 [AF Wallet] Notify individual changes from the wallet data bridge. This CL refines the way the wallet data bridge notifies about changes it writes to the local database. This CL required a minor extension in the AutofillWebDataBackend interface. The changes are not guarded behind a feature flag for wallet_metadata uss migration as they are backwards compatible for all current implementations of AutofillWebDataServiceObserverOnDBSequence. Bug: 853688 Change-Id: I3f9bd3e48c4591dddf3f645edef63d51cc8fbff8 Reviewed-on: https://chromium-review.googlesource.com/1236693 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593184} [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_profile_sync_bridge.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_webdata_backend.h [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h [modify] https://crrev.com/265dbbbd831a280c4142f40b20dee2f82fd84649/components/browser_sync/profile_sync_service_autofill_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b65eeae5889e234eb51b44a61973a387197da6a commit 0b65eeae5889e234eb51b44a61973a387197da6a Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Sep 21 15:19:34 2018 [USS] Fix a hack for populating missing wallet_data client tags This CL deals properly with the root node for wallet data. This node is sent (at least) in integration tests for migration to USS. Bug: 853688 Change-Id: I94f38e38a4f7db7a7e960e5205c64d7ad6cf49e7 Reviewed-on: https://chromium-review.googlesource.com/1238541 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#593188} [modify] https://crrev.com/0b65eeae5889e234eb51b44a61973a387197da6a/components/sync/model_impl/client_tag_based_model_type_processor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95efafd4d4579fae25eb4d76d90cdd9476801ad8 commit 95efafd4d4579fae25eb4d76d90cdd9476801ad8 Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Sep 24 15:39:27 2018 [Sync] Add a fieldtrial testing config for new impl of wallet data sync Bug: 853688 Change-Id: Idfd02f83693ad4861015d9edd3a9b23c7c6e174c Reviewed-on: https://chromium-review.googlesource.com/1238175 Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593547} [modify] https://crrev.com/95efafd4d4579fae25eb4d76d90cdd9476801ad8/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e39c85ae4ffa574205ff0603bf2747081620d99d commit e39c85ae4ffa574205ff0603bf2747081620d99d Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Sep 27 13:04:08 2018 [AF] Use AutofillMetadata in the wallet metadata bridge This CL refactors a few helpers for AutofillWalletMetadataSyncBridge with the new AutofillMetadata struct in mind. Bug: 853688 Change-Id: Idec8e641f116ad57454527a9c4b7f42a408507d7 Reviewed-on: https://chromium-review.googlesource.com/1245724 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594694} [modify] https://crrev.com/e39c85ae4ffa574205ff0603bf2747081620d99d/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/e39c85ae4ffa574205ff0603bf2747081620d99d/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/e39c85ae4ffa574205ff0603bf2747081620d99d/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2844308876309ec17a9a607ac0e4e41538c1396 commit c2844308876309ec17a9a607ac0e4e41538c1396 Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Dec 13 17:28:59 2018 [AF] Adapt sync wallet bridge to the new wallet_metadata bridge This CL makes the wallet_data bridge NOT write wallet metadata into the DB if metadata is handled by the new USS bridge. This CL is part of a new design for splitting responsibilities between the two bridges. Bug: 853688 Change-Id: Ib9299af8c1440fbf911d2a9ebe3cfa069bc29853 Reviewed-on: https://chromium-review.googlesource.com/c/1375728 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#616351} [modify] https://crrev.com/c2844308876309ec17a9a607ac0e4e41538c1396/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/c2844308876309ec17a9a607ac0e4e41538c1396/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14177d25a2a3e8e77be498efe9c5cf5abdea66be commit 14177d25a2a3e8e77be498efe9c5cf5abdea66be Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Dec 14 07:28:07 2018 [AF] User server_id as key in AutofillDataModelChange for server data This CL changes what is used as the key when notifying AutofillDataModelChange for server credit cards / server profiles. Instead of the GUID we need to notify server_id so that the wallet_metadata sync bridge can properly react to notification of type DELETE (the bridge needs the server_id of the data to generate the storage key of the metadata that should get deleted). Bug: 853688 Change-Id: Ie30a82fc8601fdf6e5428a40a00ce8f75263907e Reviewed-on: https://chromium-review.googlesource.com/c/1375991 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#616606} [modify] https://crrev.com/14177d25a2a3e8e77be498efe9c5cf5abdea66be/components/autofill/core/browser/webdata/autofill_change.h [modify] https://crrev.com/14177d25a2a3e8e77be498efe9c5cf5abdea66be/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/14177d25a2a3e8e77be498efe9c5cf5abdea66be/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc [modify] https://crrev.com/14177d25a2a3e8e77be498efe9c5cf5abdea66be/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b15890558a3e95abd7461333a9c986ec5f1139a commit 7b15890558a3e95abd7461333a9c986ec5f1139a Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Jan 08 19:16:15 2019 [AF] Enable Wallet data USS implementation by default Bug: 853688 Change-Id: I3026a36d73cf32b713c8e647fd23abe922f0387c Reviewed-on: https://chromium-review.googlesource.com/c/1377418 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#620828} [modify] https://crrev.com/7b15890558a3e95abd7461333a9c986ec5f1139a/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/7b15890558a3e95abd7461333a9c986ec5f1139a/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39dc0c1e17f5dec61482ab18100751a0bf3778ff commit 39dc0c1e17f5dec61482ab18100751a0bf3778ff Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jan 09 16:12:42 2019 [AF] Clean-up autofill_sync_bridge_util This CL cleans-up a util file doing three changes: - renames functions to make clear which are used for wallet data and which for wallet metadata; - fixes the behavior for some functions (only used from the bridge's GetAllDataForTesting()/GetAllDataForDebugging()) to make them consistent with the real production code-paths; - moves functions solely used from the data bridge to its anonymous namespace. Similar clean-up for metadata functions from autofill_sync_bridge_util will be done by a separate CL. Bug: 853688 Change-Id: I44df9fc0e60e5d7272c2ebc2005cf608dd4a86b4 Reviewed-on: https://chromium-review.googlesource.com/c/1402762 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621162} [modify] https://crrev.com/39dc0c1e17f5dec61482ab18100751a0bf3778ff/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/39dc0c1e17f5dec61482ab18100751a0bf3778ff/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/39dc0c1e17f5dec61482ab18100751a0bf3778ff/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/39dc0c1e17f5dec61482ab18100751a0bf3778ff/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c89587f3f424ef61135e5fbbc57645b2a3fdc52f commit c89587f3f424ef61135e5fbbc57645b2a3fdc52f Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jan 09 17:43:29 2019 [AF Wallet Sync] Clean-up GetAllDataForTesting()/Debugging() This CL removes unnecessary code duplication in AutofillWalletSyncBridge in the GetAllDataFor* functions. Bug: 853688 Change-Id: I9a728b8a43381265a34d1f0af1c2226100e60ccd Reviewed-on: https://chromium-review.googlesource.com/c/1403123 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621209} [modify] https://crrev.com/c89587f3f424ef61135e5fbbc57645b2a3fdc52f/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/c89587f3f424ef61135e5fbbc57645b2a3fdc52f/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/c89587f3f424ef61135e5fbbc57645b2a3fdc52f/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/c89587f3f424ef61135e5fbbc57645b2a3fdc52f/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cd2f0f7ef8ffceace2cf7b6206741895e67e907 commit 4cd2f0f7ef8ffceace2cf7b6206741895e67e907 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jan 09 19:21:27 2019 [AF Sync] Remove cache in the wallet metadata sync bridge This CL removes cache from the wallet metadata bridge. The cache is not needed in the new design. This CL temporarily regresses on the functionality to react to local data changes. Thus, it temporarily disables a couple unit-tests. Bug: 853688 Change-Id: I86269225589b016fe4fa2ee23d5c1ff99783b0e0 Reviewed-on: https://chromium-review.googlesource.com/c/1402813 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621261} [modify] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h [modify] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c816dddccba43ac6900e984b39bb4443df4157e9 commit c816dddccba43ac6900e984b39bb4443df4157e9 Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Jan 10 09:05:23 2019 [AF Sync] Make storage_key for wallet metadata encode type() This CL changes the storage_key used for wallet metadata sync bridge. We need to include the type() in the storage_key because of a difference between USS and Directory. In USS, DELETE changes are sent from the server to the bridge without the specifics (that include type()). Implementing the deletion without knowing the type() would need a hacky code, to say the least. It is okay to change the storage_key schema now because this was not defined before (in Directory) and the USS implementation has not hit any user, yet. Bug: 853688 Change-Id: I3d5504855783c089686d613822a49904eb233352 Reviewed-on: https://chromium-review.googlesource.com/c/1403417 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621512} [modify] https://crrev.com/c816dddccba43ac6900e984b39bb4443df4157e9/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/c816dddccba43ac6900e984b39bb4443df4157e9/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/c816dddccba43ac6900e984b39bb4443df4157e9/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/c816dddccba43ac6900e984b39bb4443df4157e9/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/541b05b437d7b603834735b67b2607c3f0972630 commit 541b05b437d7b603834735b67b2607c3f0972630 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Jan 11 08:41:07 2019 [AF] Add two missing metadata functions into AutofillTable This CL adds functions needed by the new wallet metadata sync bridge. Bug: 853688 Change-Id: I4b1e1c7aee0b5016eae4d7b3dd3c790d3ccf5a54 Reviewed-on: https://chromium-review.googlesource.com/c/1405509 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621949} [modify] https://crrev.com/541b05b437d7b603834735b67b2607c3f0972630/components/autofill/core/browser/webdata/autofill_table.cc [modify] https://crrev.com/541b05b437d7b603834735b67b2607c3f0972630/components/autofill/core/browser/webdata/autofill_table.h [modify] https://crrev.com/541b05b437d7b603834735b67b2607c3f0972630/components/autofill/core/browser/webdata/autofill_table_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6c0615d8efecfcee535aecc213b353d756b4467 commit b6c0615d8efecfcee535aecc213b353d756b4467 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Jan 11 18:51:19 2019 [AF] Improve logging of basic autofill types This CL simplifies debugging sync integration tests (and possibly other tasks). Bug: 853688 Change-Id: I4a72855cc400d33743cf8fc00979270af2ac92e0 Reviewed-on: https://chromium-review.googlesource.com/c/1406972 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#622073} [modify] https://crrev.com/b6c0615d8efecfcee535aecc213b353d756b4467/components/autofill/core/browser/autofill_metadata.cc [modify] https://crrev.com/b6c0615d8efecfcee535aecc213b353d756b4467/components/autofill/core/browser/autofill_metadata.h [modify] https://crrev.com/b6c0615d8efecfcee535aecc213b353d756b4467/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/b6c0615d8efecfcee535aecc213b353d756b4467/components/autofill/core/browser/credit_card.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42afdf519ce17dd7a3ca096242886dd02494c18d commit 42afdf519ce17dd7a3ca096242886dd02494c18d Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Jan 11 23:04:13 2019 [AF Sync] React to local changes in metadata sync bridge This CL re-implements how the new metadata sync bridge reacts to local changes. This CL reflects the new design for the data&metadata bridge interaction. The CL re-introduces a local cache that was recently removed because it is needed (exactly) for reacting to local changes. I am sorry for the back-and-forths. The CL also updates the implementation of Get*Data to load the data from the cache as this is needed by the unit-tests to be able to test both writing to cache and writing to the DB. Bug: 853688 Change-Id: I6de2da7b0126a05ffa13315c8376c43e9cbd5454 Reviewed-on: https://chromium-review.googlesource.com/c/1406711 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#622197} [modify] https://crrev.com/42afdf519ce17dd7a3ca096242886dd02494c18d/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/42afdf519ce17dd7a3ca096242886dd02494c18d/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h [modify] https://crrev.com/42afdf519ce17dd7a3ca096242886dd02494c18d/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4505542382777e800a8eed43793599d8407b32da commit 4505542382777e800a8eed43793599d8407b32da Author: Jan Krcal <jkrcal@chromium.org> Date: Sat Jan 12 10:39:13 2019 [AF Sync] React to remote changes in wallet metadata sync bridge This CL implements reacting to remote changes in the new wallet metadata sync bridge. Unit-tests are not part of the CL as I want to first get the bridge into state to pass integration tests (fix all issues on the way) and then only write unit-tests to test the final behavior. Bug: 853688 Change-Id: Ia9bd8157a48771a0813b326d5b82d98c3144841e Reviewed-on: https://chromium-review.googlesource.com/c/1406715 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622305} [modify] https://crrev.com/4505542382777e800a8eed43793599d8407b32da/components/autofill/core/browser/autofill_metadata.cc [modify] https://crrev.com/4505542382777e800a8eed43793599d8407b32da/components/autofill/core/browser/autofill_metadata.h [modify] https://crrev.com/4505542382777e800a8eed43793599d8407b32da/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/4505542382777e800a8eed43793599d8407b32da/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/4505542382777e800a8eed43793599d8407b32da/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/4505542382777e800a8eed43793599d8407b32da/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e25682e4fe246b9e9f3cb2850dd08ba79bc0b77 commit 1e25682e4fe246b9e9f3cb2850dd08ba79bc0b77 Author: Jan Krcal <jkrcal@chromium.org> Date: Sat Jan 12 17:43:36 2019 [AF Sync] React to initial merge in wallet metadata sync bridge This CL finally implements initial merge of sync data. With this CL, the bridge should be complete. Unit-tests are not part of the CL as I want to first get the bridge into state to pass integration tests (fix all issues on the way) and then only write unit-tests to test the final behavior. Bug: 853688 Change-Id: Ide5eab01b2408e15792b6046b67c47caa3256f90 Reviewed-on: https://chromium-review.googlesource.com/c/1406717 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622317} [modify] https://crrev.com/1e25682e4fe246b9e9f3cb2850dd08ba79bc0b77/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc [modify] https://crrev.com/1e25682e4fe246b9e9f3cb2850dd08ba79bc0b77/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8495a01fa0f1385aec0edae92a0953d81686c19c commit 8495a01fa0f1385aec0edae92a0953d81686c19c Author: Jan Krcal <jkrcal@chromium.org> Date: Sun Jan 13 11:32:13 2019 [AF Sync] Run integration tests for wallet metadata USS This CL disables the parametrization for USSWalletData and enables it for USSWalletMetadata. As a result integration tests will always use the USS implementation for wallet data (which is rolling out to Stable) and test both implementations for wallet metadata. All the tests pass (hurray!). Bug: 853688 Change-Id: I3b09d3fcf9626585f7581777340f46d14bf34733 Reviewed-on: https://chromium-review.googlesource.com/c/1406990 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622343} [modify] https://crrev.com/8495a01fa0f1385aec0edae92a0953d81686c19c/chrome/browser/sync/test/integration/wallet_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ef0c59b78b0c64c10683f2b7b5f4b0e35bc6e9 commit c4ef0c59b78b0c64c10683f2b7b5f4b0e35bc6e9 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Jan 15 12:52:13 2019 [AF Wallet] Fix non_unique_name for sync-internals This CL fixes a minor bug in the implementation of AutofillWalletSyncBridge::GetAllDataForDebugging() (which is only used by chrome://sync-internals). After this patch, non_unique_name of the entity data is a valid utf-8 string. Bug: 853688 Change-Id: If80e2381654f90f8f3716668b585ab4deb7f9f1f Reviewed-on: https://chromium-review.googlesource.com/c/1408909 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#622831} [modify] https://crrev.com/c4ef0c59b78b0c64c10683f2b7b5f4b0e35bc6e9/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/c4ef0c59b78b0c64c10683f2b7b5f4b0e35bc6e9/components/sync/model/entity_data.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cfcfb7e679f7b406834b73c9e9cabde1e82a3f3 commit 4cfcfb7e679f7b406834b73c9e9cabde1e82a3f3 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jan 16 07:25:48 2019 [AF Wallet] Parametrize USSWalletMetadata for all single_client tests As none of the other fixtures specifies the value for the USSWalletMetadata feature flag, we can parametrize all these tests as well. Bug: 853688 Change-Id: I4083a485265bc25dc03cedfb56c36f2b4c1f5dc6 Reviewed-on: https://chromium-review.googlesource.com/c/1411597 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#623146} [modify] https://crrev.com/4cfcfb7e679f7b406834b73c9e9cabde1e82a3f3/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
Comment 1 by jkrcal@chromium.org
, Jun 18 2018