New issue
Advanced search Search tips

Issue 853678 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : chrome://history text in omnibox is not seen properly when it is highlighted after dragging url to omnibox.

Reported by rp...@etouch.net, Jun 18 2018

Issue description

Version: 69.0.3464.0 (Official Build)Revision 3c26b60e3842fee660bcff5eb35aa0587d795f02-refs/branch-heads/3464@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux(14.04 LTS)OS
Pre condition : Browse some sites such as those sites appear in chrome://history page

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://history 
2. Now drag any url from chrome://history page to omnibox and observe chrome://history text
 
Actual: chrome://history text in omnibox is not seen properly when it is highlighted after dragging url to omnibox
Expected: chrome://history text in omnibox is should be seen properly when it is highlighted after dragging url to omnibox

This is regression issue, broken in ‘M 69’ and below is the bisect info :
Good build: 69.0.3456.0  (Revision: 566382).
Bad build: 69.0.3457.0 (Revision: 566678).

You are probably looking for a change made after 566659 (known good), but no later than 566665(first known bad).

Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b..986c1770a5b4c75026bedbf9bd12143bce421a29?pretty=fuller&n=50

Suspecting: r566664 from Narrow bisect

@orinj: Could you please help to reassign if your change is not the cause for this change.

Note:
1.Unable to provide bisect using per-revision script,Hence providing bisect with old script.
2.Issue is not seen on Mac(10.12.6,10.13.1,10.13.6)OS
3.This issue is also seen on all chrome internal pages and web pages.

 
Actual_video.mp4
232 KB View Download
Expected_video.mp4
155 KB View Download
Actual_screenshot.png
59.2 KB View Download
Expected_screenshot.png
57.5 KB View Download

Comment 1 by orinj@chromium.org, Jun 18 2018

Oh, sure, this is almost certainly caused by my change.  Anticipation of this kind of thing is exactly why I was at first trying to make the effect subtle but we opted in the end for a more fully selected background color.  The Expected_video above exhibits the drop-cursor bug being fixed, but it's surely preferable to the new behavior (because it was almost unnoticeable).  So we can revert for a quick fix that does no highlight (as in the video) or I can work to make the text stand out from selection background (as in the screenshot).  To keep the original bug fixed, I will work toward the latter unless the former is found preferable.
Cc: orinj@chromium.org
 Issue 854570  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cc3021383c1daeca3d92f6832522ddf2e0a3709

commit 9cc3021383c1daeca3d92f6832522ddf2e0a3709
Author: Orin Jaworski <orinj@chromium.org>
Date: Wed Jun 20 23:01:55 2018

[omnibox] Render replacement drop cursor using selection

The replacement drop cursor was being drawn with a rectangle
in the background selection color but the text was unchanged,
causing contrast problems in some environments.  This fix
renders the text using standard selection machinery so the
background and foreground colors change together.

Bug:  853678 
Change-Id: Ia641ada5100f0b88173ff6b21e776ab686553f96
Reviewed-on: https://chromium-review.googlesource.com/1106697
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569069}
[modify] https://crrev.com/9cc3021383c1daeca3d92f6832522ddf2e0a3709/ui/views/controls/textfield/textfield.cc

Comment 4 by orinj@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)

Sign in to add a comment