Regression : Browser gets crashed on hitting 'F5' key on chrome://print page.
Reported by
avsha...@etouch.net,
Jun 18 2018
|
||||||
Issue descriptionChrome Version : 69.0.3464.0 (Official Build) 3c26b60e3842fee660bcff5eb35aa0587d795f02-refs/branch-heads/3464@{#1} 32/64 bit OS : Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6), Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://print 2. Hit 'F5' key and observe. Actual Result : Browser gets crashed on hitting 'F5' key on chrome://print page. Expected Result : Browser should not crash on pressing 'F5' key on chrome://print page. Crash IDs: ------------------------ 56e55df1d7bdc2e9 (Local Crash ID: 4d93f880-b54f-46bf-813b-1b524f45c4c7) 2f842bcf8754805d (Local Crash ID: 1885a59f-acfb-43ca-9719-fb358c2db504) This is a regression issue, broken in M-69 series and providing the bisect using per-revision script: Good Build : 69.0.3457.2 (Revision : 566679) Bad Build : 69.0.3460.0 (Revision : 567312) You are probably looking for a change made after 566910 (known good), but no later than 566911 (first known bad). CHANGELOG URL : https://chromium.googlesource.com/chromium/src/+log/e77004194f84481a2dcf131c939761b1b010b312..5162124a8b00371c649fe9df551200b997cc45bd Suspect : https://chromium.googlesource.com/chromium/src/+/5162124a8b00371c649fe9df551200b997cc45bd rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You..!
,
Jun 18 2018
chrome://print is an internal debugging page, not a page that users are expected to interact with. Since this doesn't reproduce in print preview dialogs as they can't be refreshed, it probably shouldn't block Beta. Removing label and reducing priority.
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9243b4bbb1aab78972e28710a3d11add35bd7c9b commit 9243b4bbb1aab78972e28710a3d11add35bd7c9b Author: rbpotter <rbpotter@chromium.org> Date: Mon Jun 18 20:04:12 2018 Print Preview: Clear callbacks map when JS disallowed In normal print preview dialogs, the handler is destroyed with the web contents, but for the special case of chrome://print this does not occur, and old preview requests should be cleared in OnJavascriptDisallowed(). Bug: 853672 Change-Id: I5681680dc64fe020f389c6893d992694e8fcdb95 Reviewed-on: https://chromium-review.googlesource.com/1104877 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568121} [modify] https://crrev.com/9243b4bbb1aab78972e28710a3d11add35bd7c9b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
,
Jun 19 2018
Update : Retested above issue in latest Canary build #69.0.3465.0 on Windows(7, 8, 8.1, 10) & Linux (14.04 LTS) OS and the issue is fixed. Browser does not crash after pressing 'F5' key on chrome://print page. Kindly review an attached screen-cast for the reference. Note : Mac Canary build #69.0.3465.0 failed today hence can not verify this issue on Mac OS and will add TE-Verified labels once the latest Mac build gets available. Thank you..!
,
Jun 19 2018
,
Jun 20 2018
Update: Verified above issue on Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) OS using Canary build #69.0.3466.0 and the issue is fixed. No browser crash is observed in latest canary build on Mac OS, hence adding TE-Verified labels. Kindly review an attached screen-cast.
,
Jun 20 2018
Correction : Above issue is verified on Windows(7, 8, 8.1, 10), Linux(14.04 LTS) using Canary #69.0.3465.0 and on Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) OS with Canary #69.0.3466.0, hence adding TE-Verified-69.0.3465.0 & TE-Verified-69.0.3466.0 labels. Issue is fixed on all (Win, Mac & Linux) platforms and it is working as expected. Thank you..!
,
Jun 21 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rbasuvula@chromium.org
, Jun 18 2018Labels: ReleaseBlock-Beta