New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853672 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Browser gets crashed on hitting 'F5' key on chrome://print page.

Reported by avsha...@etouch.net, Jun 18 2018

Issue description

Chrome Version : 69.0.3464.0 (Official Build) 3c26b60e3842fee660bcff5eb35aa0587d795f02-refs/branch-heads/3464@{#1} 32/64 bit
OS : Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://print
2. Hit 'F5' key and observe.

Actual Result : Browser gets crashed on hitting 'F5' key on chrome://print page.

Expected Result : Browser should not crash on pressing 'F5' key on chrome://print page.

Crash IDs:
------------------------
56e55df1d7bdc2e9 (Local Crash ID: 4d93f880-b54f-46bf-813b-1b524f45c4c7)
2f842bcf8754805d (Local Crash ID: 1885a59f-acfb-43ca-9719-fb358c2db504)

This is a regression issue, broken in M-69 series and providing the bisect using per-revision script:
Good Build : 69.0.3457.2 (Revision : 566679)
Bad Build : 69.0.3460.0 (Revision : 567312)

You are probably looking for a change made after 566910 (known good), but no later than 566911 (first known bad).

CHANGELOG URL :
https://chromium.googlesource.com/chromium/src/+log/e77004194f84481a2dcf131c939761b1b010b312..5162124a8b00371c649fe9df551200b997cc45bd

Suspect : https://chromium.googlesource.com/chromium/src/+/5162124a8b00371c649fe9df551200b997cc45bd

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!
 
Actual_Result.mp4
575 KB View Download
Expected_Result.mp4
376 KB View Download
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Beta
Please find the stack trace for the crash id:
---------------------------------------------
Thread 0 (id: 0x2450) CRASHED [EXCEPTION_BREAKPOINT @ 0x00007fff929fa8b5 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x00007fff929fa8b5	(chrome.dll -print_preview_handler.cc:714 )	PrintPreviewHandler::HandleGetPreview(base::ListValue const *)
0x00007fff91961387	(chrome.dll -web_ui_impl.cc:267 )	content::WebUIImpl::ProcessWebUIMessage(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x00007fff919609d3	(chrome.dll -web_ui_impl.cc:134 )	content::WebUIImpl::OnWebUISend(content::RenderFrameHost *,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x00007fff919607b9	(chrome.dll -ipc_message_templates.h:146 )	IPC::MessageT<FrameHostMsg_WebUISend_Meta,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,void>::Dispatch<content::WebUIImpl,content::WebUIImpl,content::RenderFrameHost,void (content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &)>
0x00007fff919606d9	(chrome.dll -web_ui_impl.cc:102 )	content::WebUIImpl::OnMessageReceived(IPC::Message const &,content::RenderFrameHost *)
0x00007fff910b5bd1	(chrome.dll -web_contents_impl.cc:844 )	content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl *,IPC::Message const &)
0x00007fff910b4b55	(chrome.dll -render_frame_host_impl.cc:961 )	content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const &)
0x00007fff910b49a6	(chrome.dll -render_process_host_impl.cc:3078 )	content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const &)
0x00007fff910b488c	(chrome.dll -ipc_channel_proxy.cc:320 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &)
0x00007fff90b200d4	(chrome.dll -task_annotator.cc:101 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x00007fff90b1fbab	(chrome.dll -message_loop.cc:319 )	base::MessageLoop::RunTask(base::PendingTask *)
0x00007fff90b1f5f7	(chrome.dll -message_loop.cc:373 )	base::MessageLoop::DoWork()
0x00007fff90c0e048	(chrome.dll -message_pump_win.cc:173 )	base::MessagePumpForUI::DoRunLoop()
0x00007fff90b64067	(chrome.dll -message_pump_win.cc:56 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x00007fff90b1f150	(chrome.dll -run_loop.cc:102 )	base::RunLoop::Run()
0x00007fff90e9c233	(chrome.dll -chrome_browser_main.cc:2053 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x00007fff90e9c037	(chrome.dll -browser_main_loop.cc:976 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x00007fff90e9bfe2	(chrome.dll -browser_main_runner_impl.cc:169 )	content::BrowserMainRunnerImpl::Run()
0x00007fff9167c02e	(chrome.dll -browser_main.cc:51 )	content::BrowserMain(content::MainFunctionParams const &,std::unique_ptr<content::BrowserProcessSubThread,std::default_delete<content::BrowserProcessSubThread> >)
0x00007fff91be0e72	(chrome.dll -content_main_runner_impl.cc:621 )	content::RunBrowserProcessMain(content::MainFunctionParams const &,content::ContentMainDelegate *,std::unique_ptr<content::BrowserProcessSubThread,std::default_delete<content::BrowserProcessSubThread> >)
0x00007fff90b159db	(chrome.dll -content_main_runner_impl.cc:983 )	content::ContentMainRunnerImpl::Run()
0x00007fff90b05172	(chrome.dll -main.cc:459 )	service_manager::Main(service_manager::MainParams const &)
0x00007fff90b04a07	(chrome.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x00007fff90b01af1	(chrome.dll -chrome_main.cc:101 )	ChromeMain
0x00007ff67d4f35d5	(chrome.exe -main_dll_loader_win.cc:201 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x00007ff67d4f1698	(chrome.exe -chrome_exe_main_win.cc:230 )	wWinMain
0x00007ff67d5b0b65	(chrome.exe -exe_common.inl:283 )	__scrt_common_main_seh
0x00007fffc5391fe3	(KERNEL32.dll + 0x00011fe3 )	BaseThreadInitThunk
0x00007fffc6efcb30	(ntdll.dll + 0x0006cb30 )	RtlUserThreadStart

Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Labels: -Pri-1 -ReleaseBlock-Beta Pri-2
Status: Started (was: Assigned)
chrome://print is an internal debugging page, not a page that users are expected to interact with. Since this doesn't reproduce in print preview dialogs as they can't be refreshed, it probably shouldn't block Beta. Removing label and reducing priority.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9243b4bbb1aab78972e28710a3d11add35bd7c9b

commit 9243b4bbb1aab78972e28710a3d11add35bd7c9b
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Jun 18 20:04:12 2018

Print Preview: Clear callbacks map when JS disallowed

In normal print preview dialogs, the handler is destroyed with the web
contents, but for the special case of chrome://print this does not
occur, and old preview requests should be cleared in
OnJavascriptDisallowed().

Bug:  853672 
Change-Id: I5681680dc64fe020f389c6893d992694e8fcdb95
Reviewed-on: https://chromium-review.googlesource.com/1104877
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568121}
[modify] https://crrev.com/9243b4bbb1aab78972e28710a3d11add35bd7c9b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Comment 4 by avsha...@etouch.net, Jun 19 2018

Update : 
Retested above issue in latest Canary build #69.0.3465.0 on Windows(7, 8, 8.1, 10) & Linux (14.04 LTS) OS and the issue is fixed. Browser does not crash after pressing 'F5' key on chrome://print page.
Kindly review an attached screen-cast for the reference.

Note : Mac Canary build #69.0.3465.0 failed today hence can not verify this issue on Mac OS and will add TE-Verified labels once the latest Mac build gets available.

Thank you..!
Latest_behaviour.mp4
412 KB View Download
Status: Fixed (was: Started)

Comment 6 by avsha...@etouch.net, Jun 20 2018

Labels: TE-Verified-M69 TE-Verified-69.0.3466.0
Update:
Verified above issue on Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) OS using Canary build #69.0.3466.0 and the issue is fixed. No browser crash is observed in latest canary build on Mac OS, hence adding TE-Verified labels. Kindly review an attached screen-cast.
Mac_OS_behaviour.mov
4.6 MB View Download

Comment 7 by avsha...@etouch.net, Jun 20 2018

Labels: TE-Verified-69.0.3465.0
Correction : 
Above issue is verified on Windows(7, 8, 8.1, 10), Linux(14.04 LTS) using Canary #69.0.3465.0 and on Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) OS with Canary #69.0.3466.0, hence adding TE-Verified-69.0.3465.0 & TE-Verified-69.0.3466.0 labels. Issue is fixed on all (Win, Mac & Linux) platforms and it is working as expected.

Thank you..!

Comment 8 by avsha...@etouch.net, Jun 21 2018

Labels: ET-MUM-Reported

Sign in to add a comment