New issue
Advanced search Search tips

Issue 853643 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

PictureInPictureWindowControllerBrowserTest.CrossOriginFrameEnterLeaveCloseWindow is flaky in Win7

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 18 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ortuno@chromium.org

532114c2-843d-4f28-80af-ded81bc485c6

Builders failed on: 
- Win7 (32) Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PictureInPictureWindowControllerBrowserTest.CrossOriginFrameEnterLeaveCloseWindow

[      RUN      ] PictureInPictureWindowControllerBrowserTest.CrossOriginFrameEnterLeaveCloseWindow
[1560:3352:0618/000458.345:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=PictureInPictureWindowControllerBrowserTest.CrossOriginFrameEnterLeaveCloseWindow --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3484_9794\results3484_30226\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iogw5zil\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3484_9794\d3484_30081" --disable-offline-auto-reload --enable-experimental-web-platform-features --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=PictureInPicture,TestFeatureForBrowserTest1,UseSurfaceLayerForVideo --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[1560:6512:0618/000458.358:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[1560:3352:0618/000458.909:INFO:CONSOLE(0)] "Uncaught (in promise) InvalidStateError: Metadata for the video element are not loaded yet.", source: http://a.com:61765/media/picture-in-picture/iframe-content.html (0)
[1560:1644:0618/000458.931:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico

 

Comment 1 by ortuno@chromium.org, Jun 18 2018

Cc: -fbeaufort@chromium.org -ortuno@chromium.org
Labels: -Infra-Troopers -Sheriff-Chromium
Owner: fbeaufort@chromium.org
Status: Assigned (was: Available)
Cc: mlamouri@chromium.org
Components: Blink>Media>PictureInPicture
Status: Started (was: Assigned)
 Issue 854349  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44e1ecc1129f54d270239166ad172e197d8103fb

commit 44e1ecc1129f54d270239166ad172e197d8103fb
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Fri Jun 22 11:59:54 2018

[Picture-in-Picture] Fix browser_tests flakyness.

This makes sure video loaded in a iframe is loaded before attempting
requesting Picture-in-Picture in browser_tests.

Bug:  853643 
Change-Id: I2ad236ac24d42a89194e3dbb9ace4b9f56961d92
Reviewed-on: https://chromium-review.googlesource.com/1103570
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569581}
[modify] https://crrev.com/44e1ecc1129f54d270239166ad172e197d8103fb/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/44e1ecc1129f54d270239166ad172e197d8103fb/chrome/test/data/media/picture-in-picture/iframe-content.html
[modify] https://crrev.com/44e1ecc1129f54d270239166ad172e197d8103fb/chrome/test/data/media/picture-in-picture/iframe-test.html

Status: Fixed (was: Started)
Thanks Francois! :)

Sign in to add a comment