New issue
Advanced search Search tips

Issue 853631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-06
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus ring doesn't appear properly on checkbox after pressing tab key.

Reported by vku...@etouch.net, Jun 18 2018

Issue description

Chrome Version: 69.0.3463.0 (Official Build) (cohort: Stable)Revision	0632df721e7ac300348ef7646b571109539697e5-refs/branch-heads/3463@{#1}(32/64-bit) 
OS:Windows(7,8,8.1,10) and Linux(14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://apps/
(2)Right click on any app > click create shortcuts such that overlay appears
(3)Press tab key till focus reaches checkbox and observe the focus ring.

Actual: Focus ring doesn't appear properly on checkbox after pressing tab key.

Expected: Focus ring should be properly seen on checkbox after pressing tab key(i.e no white area between ring and checkbox border should be seen)

This is a regression issue broken in 'M68' and below is the manual regression range
Good Build: 68.0.3436.0(Revision:560158)
Bad Build:  68.0.3437.0(Revision:560453)

Note: 
Issue is not seen on Mac OS(Mac (10.12.6, 10.13.1, 10.13.5, 10.13.6) i.e there is no white area between ring and checkbox border.

 
Actual_checkbox.mp4
401 KB View Download

Comment 1 by vku...@etouch.net, Jun 18 2018

Labels: Target-69 RegressedIn-68 hasbisect FoundIn-69 FoundIn-68 Target-68
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)
Narrow bisect URL:
You are probably looking for a change made after 560276 (known good), but no later than 560280 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/b8603fb5853ddd4b32f95e2c3e3e7e124ad5028f..ea0d8268f5b4d59fb18ba1d84cc33311cb51b59d?pretty=fuller&n=50

Suspecting: r560278 ?

@ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Expected_checkbox.mov
2.3 MB View Download
NextAction: 2018-07-06
The NextAction date has arrived: 2018-07-06
Here's what I see right now (the expected look). I saw the effect mentioned in the OP at one point during development but I'm not sure if it is current.
checkbox.png
13.2 KB View Download
Status: Fixed (was: Assigned)
Calling this Fixed per #4.

Sign in to add a comment