Design proposal: https://docs.google.com/document/d/12drk9q_QjG2M6pS9dtA0_Jktdf0dt8LtRuqHzKuBBF0/edit# This enables non-ARC apps to have user preferences persisted for the intent picker on Chrome OS, and also will allow the picker to work without the ARC container running in the future.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21fd980eee731c5bb3b1e79d6d8e955e3b746c33 commit 21fd980eee731c5bb3b1e79d6d8e955e3b746c33 Author: Dominick Ng <dominickn@chromium.org> Date: Tue Jun 19 20:35:27 2018 Add the registering package name as a field on the IntentFilter struct. This CL passes the name of the package which registered a particular intent filter to the Mojo call from ARC to Chrome. The package name is added as a field on the Chrome-side IntentFilter struct. The package name is necessary to help migrate the intent picker persistence from within the ARC container to Chrome, where it can be synced across devices and be used by other app platforms. BUG=853604 Change-Id: Ie35b89bd3bf1ecfd51565d7c449287e336ae6dbc Reviewed-on: https://chromium-review.googlesource.com/1103988 Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#568591} [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/common/intent_helper.mojom [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/intent_helper/intent_filter.h [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/intent_helper/intent_filter_struct_traits.cc [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/intent_helper/intent_filter_struct_traits.h [modify] https://crrev.com/21fd980eee731c5bb3b1e79d6d8e955e3b746c33/components/arc/intent_helper/intent_filter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a69c24963659ed5ad0b488df9757c7aee4182b5 commit 4a69c24963659ed5ad0b488df9757c7aee4182b5 Author: Dominick Ng <dominickn@chromium.org> Date: Thu Jul 19 02:47:05 2018 Tidy up intent helper code. This CL removes the chromeos::AppType enum in favour of the newly introduced apps::mojom::AppType. This new enum is defined in the App Service and will be used for all app types going forward. This CL also makes a number of changes with the eventual aim of cleanly separating ARC dependencies out of AppsNavigationThrottle. These changes include: * moving page_transition_util.{_unittest.cc,cc,h} from components/arc to chrome/browser/chromeos/apps, and removing redundant includes * moving the IntentPickerResponseCallback to apps_navigation_types.h The next CL will refactor and rename ArcNavigationThrottle and AppsNavigationThrottle to encapsulate Chrome OS-only functionality more cleanly. This will allow AppsNavigationThrottle to be moved to chrome/browser/apps and reused on non-Chrome OS platforms where only desktop PWAs will be supported. BUG=853604 Change-Id: Icd8f6607dc7d1e7419564b06481031136e270553 Reviewed-on: https://chromium-review.googlesource.com/1139939 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576338} [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.h [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle_unittest.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h [rename] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/page_transition_util.cc [rename] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/page_transition_util.h [rename] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/apps/intent_helper/page_transition_util_unittest.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog_unittest.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/ui/ash/chrome_new_window_client.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/ui/views/intent_picker_bubble_view.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/ui/views/intent_picker_bubble_view.h [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/chrome/browser/ui/views/intent_picker_bubble_view_unittest.cc [modify] https://crrev.com/4a69c24963659ed5ad0b488df9757c7aee4182b5/components/arc/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Jun 19 2018