New issue
Advanced search Search tips

Issue 853594 link

Starred by 1 user
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

FilesApp UI Test console error Uncaught TypeError: Cannot read property 'updateItemByEntry' of undefined

Project Member Reported by joelhockey@chromium.org, Jun 18 2018 
UI Tests getting console errors such as:

[45883:45883:0617/201329.189334:INFO:CONSOLE(887)] "Uncaught TypeError: Cannot read property 'updateItemByEntry' of undefined", source: file:///usr/local/google/home/joelhockey/chromium/src/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (887)
[45883:45883:0617/201329.194686:INFO:CONSOLE(887)] "Uncaught TypeError: Cannot read property 'updateItemByEntry' of undefined", source: file:///usr/local/google/home/joelhockey/chromium/src/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (887)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99a0b04e55cfb10c64437d898928e9de55c43b47

commit 99a0b04e55cfb10c64437d898928e9de55c43b47
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Jun 18 04:33:41 2018

FilesApp UI tests fix Uncaught Type Error undefined updateItemByEntry

* Defer call of setupCrostini_ until after |setupAndWaitUntilReady|
  to ensure UI has been created.
* Stopped sending 'onDirectoryChanged' events for downloads and drive
  after adding new items and instead click Downloads entry to select
  it, or click Refresh button if downloads is already selected to
  ensure new items are refreshed and shown.

Bug:  853594 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I47a7e062f8d9cbce44b68ee5203f545c9635a195
Reviewed-on: https://chromium-review.googlesource.com/1103428
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567931}
[modify] https://crrev.com/99a0b04e55cfb10c64437d898928e9de55c43b47/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/99a0b04e55cfb10c64437d898928e9de55c43b47/ui/file_manager/file_manager/test/js/test_util.js

Comment 2 by joelhockey@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment