Cleanup install_hybrid_mbr |
|||
Issue description- With new util-linux, --wipe never is required. - Remove duplicate function install_hybrid_mbr() in overlays, already defined in chromeos-common.sh Blocking: b:80537490 See https://chromium-review.googlesource.com/c/chromiumos/overlays/portage-stable/+/1081298
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0788acb06ebd2f1cb0ba0726e7e5d7e0395b33a2 commit 0788acb06ebd2f1cb0ba0726e7e5d7e0395b33a2 Author: Gwendal Grignou <gwendal@chromium.org> Date: Thu Jun 21 19:17:57 2018 chromeos-common-script: Fix install_hybrid_mbr install_hybrid_mbr was not working as sfdisk was not in the path. Using sudo adds /sbin before running the command. Also, if the argument is a loop device, sudo is mandatory. The problem was hidden as overlays were re-defining install_hybrid_mbr() with proper sudo calls. Newer version of sfdisk (2.32) would wipe other partition tables by default when another tabe is modified. Add option -w never to prevent wipe when adding PMBR. BUG= chromium:853582 TEST=Check beaglebone work with Change-Id: I80b9bf8aa4ef80490ec0d70cda2b2782977f498b Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1104699 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0788acb06ebd2f1cb0ba0726e7e5d7e0395b33a2/chromeos-common-script/share/chromeos-common.sh
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/101c899bef1ef4492643a8604b1fb74b4150f6db commit 101c899bef1ef4492643a8604b1fb74b4150f6db Author: Gwendal Grignou <gwendal@chromium.org> Date: Fri Jun 22 02:56:19 2018 Remove duplicate install_hybrid_mbr install_hybrid_mbr is already defined in chromeos-common.sh. It is run when "hybrid_mbr" is specified in disk_layout.json. BUG= chromium:853582 TEST=Trybot all 3 boards, check PMBR and GPT are correct. CQ-DEPEND=CL:1104699 Change-Id: I563c9bb3796865e1cce6ffecf5b373f4a147864b Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1104701 Tested-by: Gwendal Grignou <gwendal@google.com> Reviewed-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/101c899bef1ef4492643a8604b1fb74b4150f6db/overlay-sama5d3/scripts/board_specific_setup.sh [modify] https://crrev.com/101c899bef1ef4492643a8604b1fb74b4150f6db/overlay-beaglebone/scripts/board_specific_setup.sh [add] https://crrev.com/101c899bef1ef4492643a8604b1fb74b4150f6db/overlay-raspberrypi/scripts/disk_layout.json [modify] https://crrev.com/101c899bef1ef4492643a8604b1fb74b4150f6db/overlay-raspberrypi/scripts/board_specific_setup.sh
,
Jun 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-loonix-private/+/0a1e0b5178529805d22150d19827e3403d1df54c commit 0a1e0b5178529805d22150d19827e3403d1df54c Author: Gwendal Grignou <gwendal@chromium.org> Date: Fri Jun 22 02:56:22 2018
,
Jun 22 2018
,
Aug 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gwendal@chromium.org
, Jun 18 2018