Once an extension has changed the mute state of a tab, right click -> "[un]mute site" no longer fires extension tab update event
Reported by
vince.ru...@gmail.com,
Jun 16 2018
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36 Steps to reproduce the problem: Use the attached test extension: 1. Right click an unmuted tab and click "mute site". 2. Notice that a chrome.tabs.onUpdated event is fired in the background.js console log, including the MutedInfo property. 3. Right click the tab and unmute it again. 4. Use the extension popup to mute the tab. 5. Right click that tab and click "[un]mute site". 6. Notice that a chrome.tabs.onUpdated event is not fired anymore. What is the expected behavior? The browser should always at least fire some kind of "tab updated" event when the user mutes/unmutes via right click, even if you (the developers) don't want the mute state to change. What went wrong? I've developed an extension that mutes/unmutes tabs based on their URL and a black/white list. The user has always been able to override the default list behavior by manually muting/unmuting the tab via the right click. As of recently, that has stopped being possible because tab update events no longer fire on right click after an extension has edited the tab state. My extension has a keyboard shortcut to manually override the list behavior, and chrome://flags/#enable-tab-audio-muting still seems to work as it should, but I would still like users to be able to right click to override as well. Did this work before? Yes Not sure, but this was a fairly recent regression (a few months maybe?). Does this work in other browsers? N/A Chrome version: 67.0.3396.87 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Jun 17 2018
,
Jun 18 2018
,
Jun 19 2018
Affects me as well. Chromium 67.0.3396.87 (Official Build) Arch Linux (64-bit)
,
Jun 19 2018
This is caused by the new controversial feature that mutes sites, not tabs individually, see bug 791896 . Evidently this feature implementation doesn't properly support extensions. Not sure it's possible at all.
,
Jun 20 2018
ccing steimel@ from the related issue id: 791896 and requesting to please provide inputs on the same. Note: The good and bad build for this issue is same as the issue id: 791896 Thanks...!!
,
Jun 20 2018
,
Jun 21 2018
This seems to be a feature request on the extension side. We could expose the content settings via the content settings API or have something different. We should probably leave this decision to the extensions team though. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vince.ru...@gmail.com
, Jun 16 20181.1 KB
1.1 KB Download