BreakpointManager#possibleBreakpoints fails when last column has no segment
Reported by
alec.sta...@gmail.com,
Jun 16 2018
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36 Steps to reproduce the problem: 1. open the attached "index.html" 2. try setting a breakpoint on line 4 of "main.js" What is the expected behavior? The `possibleBreakpoints` method should find the first and last segments for the clicked line. An exact match should not be required. What went wrong? The BreakpointManager's `possibleBreakpoints` method returns an empty array because no segment exists with a generated column equal to the column line 4 ends at. Did this work before? N/A Chrome version: 67.0.3396.87 Channel: stable OS Version: OS X 10.13.0 Flash Version: You'll need to fix how `startLocation` and `endLocation` are determined in the `possibleBreakpoints` method. Find all mappings within `textRange`. Pass the first and last `Location` objects to `debuggerModel.getPossibleBreakpoints`. Only return early if no mappings exist within the `textRange`.
,
Jun 19 2018
Tested the issue on chrome reported version# 67.0.3396.87 using Mac 10.12.6 with steps mentioned below: 1) Launched chrome reported version, unzipped the file and opened index.html file 2) Opened Devtools> Sources> 'main.js' and tried to se the breakpoint at line 4, but not able to se breakpoint at line 4 Observations: Also tested the issue on latest chrome# 69.0.3464.0, followed above mentioned steps and able to set breakpoint at line 4 @Reporter: Please find the attached screencast screencast for your reference and let us know if you are also pointing the same issue which i have captured in the screencast, provide your feedback on it which help in further triaging the issue. Thanks!
,
Jun 19 2018
Awesome! Thanks for the update. :)
,
Jun 19 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2018
Able to reproduce the issue on reported version 67.0.3396.87 and the same is not seen on latest canary 69.0.3468.0 and Beta 68.0.3440.33 using Windows 10, Ubuntu 14.04 & Mac 10.12.6, hence providing reverse bisect info Reverse Bisect Info: ================ Last Bad build: 68.0.3417.0 First Good build: 68.0.3418.0 You are probably looking for a change made after 555625 (known good), but no later than 555626 (first known bad). https://chromium.googlesource.com/chromium/src/+log/9cf9c0c56edce812ea5cf934aff4bbc7d571c9b6..21d0de4658af012ce154176229d8a23609bb1d02 Reviewed-on: https://chromium-review.googlesource.com/1028510 @Alexey Kozyatinskiy: Please confirm the issue and help in re-assigning if it is not related to your change, please help in merging it to M-67 if applicable Adding ReleaseBlock-Stable for M-67, feel free to remove it if not applicable. Note: CC'ing the reviewer(Dmitry Gozman) as the author of this issue(Alexey Kozyatinskiy) last visit is 17 days ago. Thanks!
,
Jun 22 2018
Not a blocker for 67.
,
Jun 22 2018
Probably a dupe of issue 836440? kozy@ to confirm.
,
Jun 22 2018
Yes, I believe it is dupe. I can verify that it works as expected in dev and latest Canary. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by susan.boorgula@chromium.org
, Jun 17 2018