Issue metadata
Sign in to add a comment
|
[MdRefresh] Regression: Spacing between Extension Toolbar Buttons is broken |
||||||||||||||||||||||
Issue descriptionChrome Version: Canary 69.0.3461.2 OS: macOS 10.13 (but probably OS=All) What steps will reproduce the problem? (1) Install two extension (2) Hover over their icons on the Toolbar What is the expected result? There should be 4px spacing. What happens instead? There is 0px spacing. Seems to be regression in recent Canary. A screencast is attached. Thanks Mehmet
,
Jun 18 2018
Not a regression on Windows 10 Canary 69.0.3464.0. This behavior doesn't make sense to me unless features::kViewsBrowserWindows is disabled (but you're obviously using a views window), the layout constants used by ToolbarActionsBar should be the same on all platforms. + Mac folks as an initial shot in the dark. Any chance that the views window is turned on in a different way so that this feature is no longer enabled? Related code check: https://cs.chromium.org/chromium/src/chrome/browser/ui/toolbar/toolbar_actions_bar.cc?l=141&rcl=e17296f164793f5797524fdbbe312823e64b5cd9
,
Jun 19 2018
Maybe interesting: I see the issue with the 0px spacing between the extension icons on a device with latest macOS 10.13.4, but on another device with macOS 10.12.6 the spacing looks fine with 4px between the icons. Maybe macOS 10.13.x-specific?
,
Jun 19 2018
This the behavior on macOS 10.12: 1.) Spacing okay 2.) CMD-Q to close the window 3.) Restart Canary -> Spacing is broken 4.) CMD-Q to close the window 5.) Restart Canary -> Spacing is okay 6.) CMD-Q to close the window 7.) Restart Canary -> Spacing is broken 8.) CMD-Q to close the window 9.) Restart Canary -> Spacing is okay and so on... this is really strange :-( A screencast is attached.
,
Jun 19 2018
Same behavior on macOS 10.13.4 as described in c#4.
,
Jun 19 2018
Thanks! I'll take this since it may be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1091416 (if not now, a later patchset)
,
Jul 12
,
Jul 12
Is this fixed?
,
Jul 12
Can not repro anylonger - I think this was fixed in issue 859048 , which was a similar bug.
,
Jul 17
Marking fixed then. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by robliao@chromium.org
, Jun 18 2018Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)