New issue
Advanced search Search tips

Issue 853449 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Stack-overflow in blink::CSSParserImpl::ConsumeMediaRule

Project Member Reported by ClusterFuzz, Jun 16 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6387697061724160

Fuzzer: libFuzzer_stylesheet_contents_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Stack-overflow
Crash Address: 0x7fff523acee8
Crash State:
  blink::CSSParserImpl::ConsumeMediaRule
  blink::CSSParserImpl::ConsumeAtRule
  bool blink::CSSParserImpl::ConsumeRuleList<blink::CSSParserImpl::ConsumeMediaRul
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6387697061724160

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 

Comment 1 by cnardi@chromium.org, Jun 18 2018

Components: Blink>CSS
Project Member

Comment 2 by ClusterFuzz, Jun 19 2018

Labels: Test-Predator-Auto-Owner
Owner: shend@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/34de07a7da1921205306d2f6299187dcddd42d2d ([CSSParser] Use streaming parser for CSS parsing.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by shend@chromium.org, Jun 19 2018

Cc: e...@chromium.org
Hi Emil, do you think this is worth fixing? The test case is just like >10,000 nested @media rules.

Comment 4 by e...@chromium.org, Jun 19 2018

Status: WontFix (was: Assigned)
No, in general deeply nested cases like this that are only seen through fuzzing isn't worth fixing. Unless of course it has security implications.

Project Member

Comment 5 by ClusterFuzz, Jun 26 2018

Labels: Needs-Feedback
ClusterFuzz testcase 6387697061724160 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.

Comment 6 by shend@chromium.org, Jun 26 2018

Labels: ClusterFuzz-Ignore
Project Member

Comment 7 by ClusterFuzz, Aug 10

ClusterFuzz has detected this issue as fixed in range 581993:582026.

Detailed report: https://clusterfuzz.com/testcase?key=6387697061724160

Fuzzer: libFuzzer_stylesheet_contents_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Stack-overflow
Crash Address: 0x7fff523acee8
Crash State:
  blink::CSSParserImpl::ConsumeMediaRule
  blink::CSSParserImpl::ConsumeAtRule
  bool blink::CSSParserImpl::ConsumeRuleList<blink::CSSParserImpl::ConsumeMediaRul
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=504996:505024
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=581993:582026

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6387697061724160

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment