New issue
Advanced search Search tips

Issue 853429 link

Starred by 1 user
Status: Assigned
Owner:
carlosk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Assess if last_n saves too many times the same page and address it if needed

Project Member Reported by carlosk@chromium.org, Jun 16 2018 
Last_n waits for tab-hidden events to save snapshots of pages in tabs, but does so independently of the contents of the page having changed since a previous snapshot. As saving a snapshot is a resource "heavy" activity we would like to:
a) Evaluate if it is really the case that pages are often saved more than once.
b) If that is the case, investigate way to address that problem.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93bf475854392475f6a7c3859ae07f536fe45037

commit 93bf475854392475f6a7c3859ae07f536fe45037
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Thu Jun 21 23:38:23 2018

Add metric to track same-page snapshot saves by last_n

This metric will assist in figuring out if there is the need to better
track actual content changes to pages saved more than once by last_n.
Tests were also updated to check this (and another) metric(s) are being
properly reported.

Bug: 853429
Change-Id: I79e84b9d0de543d202307a357556056a7f835781
Reviewed-on: https://chromium-review.googlesource.com/1103616
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569451}
[modify] https://crrev.com/93bf475854392475f6a7c3859ae07f536fe45037/chrome/browser/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/93bf475854392475f6a7c3859ae07f536fe45037/chrome/browser/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/93bf475854392475f6a7c3859ae07f536fe45037/chrome/browser/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/93bf475854392475f6a7c3859ae07f536fe45037/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/93bf475854392475f6a7c3859ae07f536fe45037/tools/metrics/histograms/histograms.xml

Comment 2 by carlosk@chromium.org, Jul 10 

From initial Canary/Dev data: 40% of last_n snapshots fall in the "Same page, same expected quality" bucket. I'd like to get data at least from Beta before making a decision but this indicates we have room for improvement.
►

Sign in to add a comment