New issue
Advanced search Search tips

Issue 853411 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in chrome

Project Member Reported by ClusterFuzz, Jun 16 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4651789258063872

Fuzzer: bj_broddelwerk
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000038
Crash State:
  chrome
  blink::ComputedStyle::IsDisplayBlockContainer
  blink::FirstLetterPseudoElement::DidRecalcStyle
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=567604:567614

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4651789258063872

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 16 2018

Components: Blink>CSS Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 16 2018

Labels: Test-Predator-Auto-Owner
Owner: futhark@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/9b2c8f90be4d44a0fa8799d3253820e975841e52 ([Squad] Remove special code path for reattach recalc.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de5c18194ce923fa5eeec84881ffcf96554d98f7

commit de5c18194ce923fa5eeec84881ffcf96554d98f7
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Jun 18 14:59:25 2018

Do not override kReattach for ::first-letter.

We incorrectly did an override with kForce for ::first-letter recalc
when we were already recalculating style for re-attachment (kReattach).
This caused crashes in FirstLetterPseudoElement::DidRecalcStyle.

Bug:  853621 ,  853476 ,  853471 ,  853470 ,  853433 ,  853411 
Change-Id: Id34e6bdbaaeb3b4933a3e963b68f0bffcda0e40e
Reviewed-on: https://chromium-review.googlesource.com/1104176
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568006}
[add] https://crrev.com/de5c18194ce923fa5eeec84881ffcf96554d98f7/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-block-to-inline-ref.html
[add] https://crrev.com/de5c18194ce923fa5eeec84881ffcf96554d98f7/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-block-to-inline.html
[modify] https://crrev.com/de5c18194ce923fa5eeec84881ffcf96554d98f7/third_party/blink/renderer/core/dom/element.cc

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Jun 19 2018

Labels: -Reproducible Unreproducible
ClusterFuzz testcase 4651789258063872 appears to be flaky, updating reproducibility label.

Sign in to add a comment