DCHECK when focusing fakebox with UIRefresh disabled |
||
Issue description
1. --disable-features=UIRefreshPhase1 to turn off the experiment
2. Launch chrome and focus the fakebox on the NTP.
[0615/205144.694545:FATAL:omnibox_text_field_ios.mm(306)] Check failed: !IsRefreshLocationBarEnabled().
(lldb) bt
* thread #1, name = 'CrWebMain', queue = 'com.apple.main-thread', stop reason = EXC_BREAKPOINT (code=EXC_I386_BPT, subcode=0x0)
frame #0: 0x0000000107fbf534 Chromium`base::debug::BreakDebugger() at debugger_posix.cc:269
frame #1: 0x0000000107d2441b Chromium`logging::LogMessage::~LogMessage(this=0x00007ffee9c452c0) at logging.cc:855
frame #2: 0x0000000107d20eb5 Chromium`logging::LogMessage::~LogMessage(this=0x00007ffee9c452c0) at logging.cc:586
* frame #3: 0x0000000107427c10 Chromium`::-[OmniboxTextFieldIOS addExpandOmniboxAnimations:completionAnimator:](self=0x00007fe1ad04e600, _cmd="addExpandOmniboxAnimations:completionAnimator:", animator=0x000061800016aec0, completionAnimator=0x000061800016e340) at omnibox_text_field_ios.mm:306
frame #4: 0x000000010757af26 Chromium`::-[LocationBarLegacyView addExpandOmniboxAnimations:completionAnimator:](self=0x00007fe1ac91e510, _cmd="addExpandOmniboxAnimations:completionAnimator:", animator=0x000061800016aec0, completionAnimator=0x000061800016e340) at location_bar_legacy_view.mm:267
frame #5: 0x0000000107574376 Chromium`::-[LocationBarLegacyCoordinator addExpandOmniboxAnimations:completionAnimator:](self=0x00006080000d4ba0, _cmd="addExpandOmniboxAnimations:completionAnimator:", animator=0x000061800016aec0, completionAnimator=0x000061800016e340) at location_bar_legacy_coordinator.mm:183
frame #6: 0x0000000107461ed0 Chromium`::-[ToolbarCoordinator expandOmniboxAnimated:](self=0x00006080000ffb80, _cmd="expandOmniboxAnimated:", animated=NO) at toolbar_coordinator.mm:544
frame #7: 0x000000010745f890 Chromium`::-[ToolbarCoordinator focusFakebox](self=0x00006080000ffb80, _cmd="focusFakebox") at toolbar_coordinator.mm:382
frame #8: 0x0000000107336574 Chromium`::-[ContentSuggestionsHeaderViewController fakeOmniboxTapped:](self=0x00007fe1aa63fcd0, _cmd="fakeOmniboxTapped:", sender=0x00007fe1ac8641d0) at content_suggestions_header_view_controller.mm:402
frame #9: 0x0000000111dbfd82 UIKit`-[UIApplication sendAction:to:from:forEvent:] + 83
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c6db333c9286c8f9098b18d061bf821d88d616d commit 6c6db333c9286c8f9098b18d061bf821d88d616d Author: Rohit Rao <rohitrao@chromium.org> Date: Sat Jun 16 02:28:17 2018 [ios] Ties the RefreshLocationBar experiment to UIRefreshPhase1. The new location bar implementation requires that the UIRefreshPhase1 experiment also be enabled. When UIRefreshPhase1 is disabled, also disable RefreshLocationBar. BUG= 853408 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia0266255cd59ca7487d766928846439a2ac8eed0 Reviewed-on: https://chromium-review.googlesource.com/1103524 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567865} [modify] https://crrev.com/6c6db333c9286c8f9098b18d061bf821d88d616d/ios/chrome/browser/ui/ui_util.mm
,
Jun 18 2018
Fixed thanks to Rohit's CL above. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by rohitrao@chromium.org
, Jun 16 2018