Re-enable NotificationPlatformBridgeTest#testPermissionGranted and testPermissionDenied |
|||
Issue description
Right now they appear to consistently fail when looking for infobars.
However they pass* with the following test annotation:
@CommandLineFlags.Add("disable-features=" + ChromeFeatureList.MODAL_PERMISSION_PROMPTS)
(Copied from chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java )
This leads me to conclude they simply need to be updated to look for and tap on the relevant modal dialog buttons.
*well, they appear to pass, but they were originally disabled due to a native crash that occurs ~6% of the time on a similar test (see Issue 707528). So they will probably still require a @RetryOnFailure annotation.
,
Jul 18
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86fa36bec14779d79650ef33f446a162b3610947 commit 86fa36bec14779d79650ef33f446a162b3610947 Author: Anita Woodruff <awdf@chromium.org> Date: Wed Jul 25 15:23:00 2018 [Android Tests] Fix up disabled tests in NotificationPlatformBridgeTest - Turns out these tests were failing because notification permissions were switched from info bars to modals a while ago and these tests were never updated. Bug: 853405 Change-Id: Ia663240507a7fa674f96170c4fdcbfdc9c028ec9 Reviewed-on: https://chromium-review.googlesource.com/1145309 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#577898} [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestRule.java [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/QuotaTest.java [modify] https://crrev.com/86fa36bec14779d79650ef33f446a162b3610947/chrome/test/data/notifications/android_test.html
,
Jul 31
|
|||
►
Sign in to add a comment |
|||
Comment 1 by awdf@chromium.org
, Jul 18