New issue
Advanced search Search tips

Issue 853370 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Refresh: omnibox background is grey while text background is white

Project Member Reported by bsep@chromium.org, Jun 15 2018

Issue description

Seems to happen consistently on Windows 10. Screenshot attached.

Steps to reproduce:
1. Type something in the omnibox
2. Unfocus the omnibox
3. Click on the omnibox (do not use a keyboard shortcut)

The text will have a white background but the rest of the omnibox will still be grey.
 
omnibox-text-background.PNG
49.8 KB View Download
Cc: tommycli@chromium.org
Owner: manukh@chromium.org
Might be another good first-bug type thing to look at.

Look at LocationBarView and OmniboxViewViews with upcoming-ui-features on. I have code in there to make the background change color when you focus and blur.

There is likely a flaw in this logic to lead to the above bug.

Comment 2 by manukh@chromium.org, Jun 19 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b864f444230a2e0857b84475f4805c2f6c6cab

commit a9b864f444230a2e0857b84475f4805c2f6c6cab
Author: manuk <manukh@chromium.org>
Date: Mon Jun 25 19:07:50 2018

Schedule repaint of location bar when its background is modified.

This issue was most noticeable when quickly alt-tabbing away and back to chrome, or blurring and re-focusing the omnibox. The omnibox schedules a repaint for the location bar when it blurs, but not when it focuses. This caused the region of the location bar that is not overlapped by the omnibox to be stale when the omnibox gains focus quickly after losing focus; the omnibox would be painted with its focus-color (white) while the location bar would retain its blur-color (light gray). This was not an issue prior to material refresh because the omnibox and location bar did not change color on focus and blur.

Bug:  853370 
Change-Id: I7c6035a09e76cf9fff019234e769ffc312b0a9bd
Reviewed-on: https://chromium-review.googlesource.com/1112494
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570119}
[modify] https://crrev.com/a9b864f444230a2e0857b84475f4805c2f6c6cab/chrome/browser/ui/views/location_bar/location_bar_view.cc

Comment 4 by manukh@chromium.org, Jun 26 2018

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tested this issue on Windows 10 on the build without fix 69.0.3469.3 and unable to reproduce the issue by following the below steps.

1. Launched Chrome, set #top-chrome-md flag to refresh and relaunched Chrome
2. On a new tab, entered some text in the omnibox, clicked outside of the omnibox to remove focus and clicked on the text with mouse to select the text.
3. Cannot observe any grey background for the omnibox.
Attached is the screen cast for reference.

manukh@ Request you to check and confirm if anything is missed from our end in verifying the issue?

Thanks..
853370.mp4
852 KB View Download

Comment 6 by manukh@chromium.org, Jun 26 2018

susan.boorgula@, 

The defect only appeared occasionally, and was more likely to appear when re-focusing the omnibox rapidly. An easy way I found to reproduce it and then verify the fix on Linux was to

1. launch chrome with refresh flag
2. enter text into the omnibox and click outside the omnibox to blur it
3. Press ctrl+L to focus the omnibox
4. Press tab to blur the omnibox
5. repeat steps 3 and 4 rapidly

Also to note, the defect would disappear when the mouse was over the left or right edges of the omnibox; so to be safe, the mouse should be kept away from the edges of the omnibox.
Cc: manukh@chromium.org
 Issue 853632  has been merged into this issue.

Sign in to add a comment