New issue
Advanced search Search tips

Issue 853369 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Update/add UMA metrics

Project Member Reported by taku...@chromium.org, Jun 15 2018

Issue description

Go through Media Router metrics.
- If a metric can be shared between WebUI and Views, make sure it is used by Views as well
- If a metric cannot be shared, then add a new one.
 

Comment 1 by mfo...@chromium.org, Jun 25 2018

Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/564dee43efc1579ab363945e02ef64d8aad1bb12

commit 564dee43efc1579ab363945e02ef64d8aad1bb12
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Mon Jul 02 19:59:23 2018

[Harmony Cast Dialog] Make UMA metrics support the dialog

Make the Harmony dialog record the following metrics. These are existing
metrics already used by the WebUI dialog.

MediaRouter.Ui.Device.Count
MediaRouter.Ui.Action.StartLocalPosition
MediaRouter.Ui.Dialog.Paint

Bug:  853369 
Change-Id: Ie49a969faa0d91ec8026a55b2f2be15dd25f26ea
Reviewed-on: https://chromium-review.googlesource.com/1119055
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571979}
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/ui/views/media_router/cast_dialog_view.h
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/564dee43efc1579ab363945e02ef64d8aad1bb12/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d1dd4de58ba9d40b978ec3145baf1f8c1797173

commit 9d1dd4de58ba9d40b978ec3145baf1f8c1797173
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Sat Jul 14 01:07:40 2018

[Harmony Cast Dialog] Add CastDialogMetrics

Add CastDialogMetrics, which will be used by CastDialogView to
record various UI metrics. The recorder will keep track of when/if
certain events (init, paint, load sinks, first user action) happened,
to record when an event happens for the first time, and the durations
between events.

MediaRouterMetrics calls that CastDialogView was making directly will
now go through CastDialogMetrics.

Metrics recorded by CastDialogMetrics via MediaRouterMetrics:
MediaRouter.Ui.Device.Count
MediaRouter.Ui.Dialog.Paint
MediaRouter.Ui.Dialog.LoadedWithData (new)
MediaRouter.Ui.Action.StartLocalPosition
MediaRouter.Ui.Action.CloseLatency (new)
MediaRouter.Ui.Action.StartLocal.Latency (new)
(MediaRouter.Ui.FirstAction will be added later)
(MediaRouter.Ui.Action.StopRoute will be added later)

Bug:  853369 
Change-Id: Ib27ecc9293fd148d8592b76b22c9fbab3910a5e5
Reviewed-on: https://chromium-review.googlesource.com/1135582
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575129}
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/views/media_router/cast_dialog_metrics.cc
[add] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/views/media_router/cast_dialog_metrics.h
[add] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/views/media_router/cast_dialog_metrics_unittest.cc
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/views/media_router/cast_dialog_view.h
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/9d1dd4de58ba9d40b978ec3145baf1f8c1797173/chrome/test/BUILD.gn

Labels: -Target-69 Target-70
Labels: -M-69 M-70
Blocking: -754101
We need two more metrics, MediaRouter.Ui.FirstAction and MediaRouter.Ui.Action.StopRoute, for the Views dialog to reach parity with the WebUI dialog. Since those are nice-to-haves that won't influence our launch decision, I'll label this as a non-blocker for launch to prioritize other blockers.
Cc: powerb@chromium.org
Labels: -Pri-1 -M-70 M-71 Pri-2
Labels: -Target-70 -M-71 Target-72 M-72
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edc8dbda486880981b8bdf85a6d2ed47c6d37f14

commit edc8dbda486880981b8bdf85a6d2ed47c6d37f14
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Mon Nov 19 23:03:17 2018

[Harmony Cast Dialog] Record route stopping in metrics

Record the event of user stopping a route in
MediaRouter.Ui.FirstAction and MediaRouter.Ui.Action.StopRoute.

The UIMediaSink struct now contains MediaRoute as a property, so that
CastDialogView can determine whether a route is local or remote.

Bug:  853369 
Change-Id: I89052163e4de721164a1b4fe61e7b1cdeb1fad12
Reviewed-on: https://chromium-review.googlesource.com/c/1324131
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609485}
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/media_router/cast_dialog_model.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/media_router/ui_media_sink.h
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/cast_dialog_metrics.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/cast_dialog_metrics.h
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/cast_dialog_metrics_unittest.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/chrome/test/media_router/media_router_ui_for_test.cc
[modify] https://crrev.com/edc8dbda486880981b8bdf85a6d2ed47c6d37f14/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment