New issue
Advanced search Search tips

Issue 853368 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Change the icon used in no-devices view

Project Member Reported by taku...@chromium.org, Jun 15 2018

Issue description

Per discussions with Amy, the icon shown on the left side of the no-devices view should be the Chromecast logo on Chrome builds and the input logo on Chromium builds.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/cloudview-team/media-router/internal/+/f4d7d241988af1e6fa5d16fe6c434202411fa462

commit f4d7d241988af1e6fa5d16fe6c434202411fa462
Author: Takumi Fujimoto <takumif@google.com>
Date: Mon Jun 18 18:57:37 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/208cf41c691bb5f5851630c661426bc5a880ba1a

commit 208cf41c691bb5f5851630c661426bc5a880ba1a
Author: Takumi Fujimoto <takumif@google.com>
Date: Mon Jun 18 19:29:54 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df53f0e5617cd6f2475e47c9e2193b8eabef737

commit 0df53f0e5617cd6f2475e47c9e2193b8eabef737
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 19 22:55:02 2018

Roll src-internal dd1a2724e60e..208cf41c691b (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd1a2724e60e..208cf41c691b


Created with:
  gclient setdep -r src-internal@208cf41c691b

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:853368 
TBR=mmoss@chromium.org

Change-Id: I2711ddb8757e18dad036816b7b4eca511f4b1a66
Reviewed-on: https://chromium-review.googlesource.com/1106564
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568627}
[modify] https://crrev.com/0df53f0e5617cd6f2475e47c9e2193b8eabef737/DEPS

Comment 4 by mfo...@chromium.org, Jun 25 2018

Blocking: -754101
Labels: -Pri-1 -Type-Bug Pri-2 Type-Feature
Not much work remains, but not blocking

Labels: -M-69 -Target-69 Target-70 M-70
Cc: powerb@chromium.org
Labels: -Target-70 -M-70 Target-71 M-71
Status: WontFix (was: Assigned)
Per the new mocks, we'll be showing a throbber instead of an icon.
presentation/d/1q2scOvS_tGbl8H0MMbfJ3jNTIuH4ZDMI9FhOyZgs634/edit#slide=id.g4028094dfd_3_160

Sign in to add a comment