New issue
Advanced search Search tips

Issue 853360 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

fast/css/input-search-padding.html and 23 other(s) in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 15 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dpranke@google.com

fast/css/input-search-padding.html and 23 other(s) in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29


 
Cc: -dpranke@google.com robertma@chromium.org
Owner: dpranke@chromium.org
Status: Assigned (was: Available)
I think these just need new 10.13 baselines, given the weirdness in coverage on 10.13 at the moment (see bug 853356).
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/440e14b02c86e66a991fa407d02df56c0fef64db

commit 440e14b02c86e66a991fa407d02df56c0fef64db
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Jun 15 22:07:07 2018

Suppress 10.13 layout test failures so that they can be rebaselined.

TBR=robliao@chromium.org
NOTRY=true
BUG=853360

Change-Id: I5c3a4ee9a99af7cda1103d7def48685496462b49
Reviewed-on: https://chromium-review.googlesource.com/1103308
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567810}
[modify] https://crrev.com/440e14b02c86e66a991fa407d02df56c0fef64db/third_party/WebKit/LayoutTests/TestExpectations

Status: Started (was: Assigned)
Components: Blink>Paint
Labels: -Sheriff-Chromium
two more failures left ... working on those now.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bdc946b2c56e02dfbe0866c57c8664fb2fe313e

commit 4bdc946b2c56e02dfbe0866c57c8664fb2fe313e
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sat Jun 16 01:40:01 2018

Add two more failing webkit_layout_tests on Mac10.13

TBR=robliao@chromium.org
BUG=853360
NOTRY=true

Change-Id: Id50cc9e6fc255f2bdafad60468540209075db893
Reviewed-on: https://chromium-review.googlesource.com/1103615
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567856}
[modify] https://crrev.com/4bdc946b2c56e02dfbe0866c57c8664fb2fe313e/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e31eb48e3069801246dd71260103b9d1dc47d46

commit 7e31eb48e3069801246dd71260103b9d1dc47d46
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sat Jun 16 02:07:41 2018

Update baselines for failing 10.13 tests.

BUG=853360
TBR=robliao@chromium.org
NOTRY=true

Change-Id: Iac99d5fa87605d7a01cd2e2d232d4c154525446b
Reviewed-on: https://chromium-review.googlesource.com/1103312
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567863}
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/month-picker-appearance-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/week-picker-appearance-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/text/input-table-expected.txt
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/http/tests/inspector-protocol/page/page-lifecycleEvents-expected.txt
[delete] https://crrev.com/bb770d9123eeaef39fd6c5f740c130f15b0c6c83/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/css/input-search-padding-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/month-picker-appearance-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/week-picker-appearance-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/listbox-with-display-none-option-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-rtl-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-table-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-table-expected.txt
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/fast/text/drawBidiText-expected.png
[add] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/http/tests/inspector-protocol/page/page-lifecycleEvents-expected.txt
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[rename] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/7e31eb48e3069801246dd71260103b9d1dc47d46/third_party/WebKit/LayoutTests/platform/mac/virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance-expected.png

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3e44fd1d84be46fd1d44bba9a374fd10f633bd9

commit f3e44fd1d84be46fd1d44bba9a374fd10f633bd9
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sun Jun 17 20:42:28 2018

Suppress more layout test failures on the Mac builders.

As part of cleaning up tryserver.blink and chromium.webkit I need
to green up all of the Mac builders. I think most of these failures
are either flakes or need rebaselines, but I'll suppress them first
and then work through them.

TBR=robertma@chromium.org
NOTRY=true
BUG=853360

Change-Id: Ib15695a2c7e6f0e077fe5de08b2802713e51d6d3
Reviewed-on: https://chromium-review.googlesource.com/1103714
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567915}
[modify] https://crrev.com/f3e44fd1d84be46fd1d44bba9a374fd10f633bd9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4973655b5992c480397460dfe1aa522438fea68

commit e4973655b5992c480397460dfe1aa522438fea68
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sun Jun 17 22:45:41 2018

Mark two more layout tests as failing on 10.13 debug.

TBR=robertma@chromium.org
BUG=853360
NOTRY=true

Change-Id: Ic5dac923094175223964c999b74f41f82273f63f
Reviewed-on: https://chromium-review.googlesource.com/1103839
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567917}
[modify] https://crrev.com/e4973655b5992c480397460dfe1aa522438fea68/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a83801ab9a87b916ed7bfefd8a6cad878d4f8ea0

commit a83801ab9a87b916ed7bfefd8a6cad878d4f8ea0
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Jun 18 08:09:11 2018

sheriff: Disable more flaky layout tests

TBR=robertma@chromium.org
BUG=853360
NOTRY=true

Change-Id: I61d13bce4af0cc83d2630b60d67963ef87b1ae20
Reviewed-on: https://chromium-review.googlesource.com/1104059
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567947}
[modify] https://crrev.com/a83801ab9a87b916ed7bfefd8a6cad878d4f8ea0/third_party/WebKit/LayoutTests/TestExpectations

Owner: ----
Status: Untriaged (was: Started)
I think I've lost the context at this on this point, so un-assigning in case someone else wants to look at these failures and update the baselines, if this is even still relevant; this might need re-triaging.
Status: Available (was: Untriaged)
At some point I'll look into this, but leaving Available for now.

Sign in to add a comment