New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853354 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

openSuse Leap 15 is not correctly detected

Project Member Reported by timbrown@google.com, Jun 15 2018

Issue description

For the distro histogram, we currently only check for openSuse "15", but it's actually "15.0". Therefore the count of users will currently go into "other".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6268c97f272cc90dd749313ba2c82ce7000996ac

commit 6268c97f272cc90dd749313ba2c82ce7000996ac
Author: Tim Brown <timbrown@chromium.org>
Date: Mon Jun 18 21:52:35 2018

Update linux distro histogram for Leap 15.*

It turns out that openSuse decided to call the version "15.0", not "15",
so we aren't currently detecting it. Also, there are two guaranteed
point releases, so support for detecting those has been added already.

I've also added thomasanderson@ as a co-owner of the histogram.

Bug:  853354 
Change-Id: I6867e13833744f4fa0013b1f505c318cc3893051
Reviewed-on: https://chromium-review.googlesource.com/1103279
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568179}
[modify] https://crrev.com/6268c97f272cc90dd749313ba2c82ce7000996ac/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
[modify] https://crrev.com/6268c97f272cc90dd749313ba2c82ce7000996ac/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6268c97f272cc90dd749313ba2c82ce7000996ac/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment