Cache icon for Chrome Web Store |
|||||||
Issue descriptionChrome Version: 69.0.3461.2 The initial Chrome Web Store tile does not have a cached icon, so a gray fallback is returned instead. since this is always shown for new profiles, we should force it to be cached with a rule on the backend.
,
Jul 20
I can take that, if you'd like
,
Jul 23
,
Jul 23
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8b6230848f81a3308998bf3cf97edff2f657a09 commit d8b6230848f81a3308998bf3cf97edff2f657a09 Author: Mathieu Perreault <mathp@chromium.org> Date: Tue Jul 24 16:46:10 2018 [New Tab] Provide icons for the prepopulated pages on the NTP. Web Store will have an icon now! Bug: 853349 Test: out/Default/ntp_render_browsertests Change-Id: I46182b509b08d2772cb2a439f60f0a3313e5cb81 Reviewed-on: https://chromium-review.googlesource.com/1147105 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577578} [modify] https://crrev.com/d8b6230848f81a3308998bf3cf97edff2f657a09/chrome/browser/history/top_sites_factory.cc [modify] https://crrev.com/d8b6230848f81a3308998bf3cf97edff2f657a09/chrome/browser/search/ntp_icon_source.cc [modify] https://crrev.com/d8b6230848f81a3308998bf3cf97edff2f657a09/components/test/data/ntp/render/1200x800_DefaultMV.png
,
Jul 24
,
Jul 25
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
Pls merge your change to M69 branch 3497 latest by 3:00 PM PT today, Wednesday (07/25/18). Thank you.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7993131a1111604a42b1e839ad474adb5f4bf028 commit 7993131a1111604a42b1e839ad474adb5f4bf028 Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Jul 25 18:43:40 2018 [New Tab] Provide icons for the prepopulated pages on the NTP. Web Store will have an icon now! TBR=mathp@chromium.org (cherry picked from commit d8b6230848f81a3308998bf3cf97edff2f657a09) Bug: 853349 Test: out/Default/ntp_render_browsertests Change-Id: I46182b509b08d2772cb2a439f60f0a3313e5cb81 Reviewed-on: https://chromium-review.googlesource.com/1147105 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577578} Reviewed-on: https://chromium-review.googlesource.com/1150430 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#81} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/7993131a1111604a42b1e839ad474adb5f4bf028/chrome/browser/history/top_sites_factory.cc [modify] https://crrev.com/7993131a1111604a42b1e839ad474adb5f4bf028/chrome/browser/search/ntp_icon_source.cc [modify] https://crrev.com/7993131a1111604a42b1e839ad474adb5f4bf028/components/test/data/ntp/render/1200x800_DefaultMV.png |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by twelling...@chromium.org
, Jun 19 2018