^^^
what is security level here ?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52104cbdba78f005035924144aab201dce615b15 commit 52104cbdba78f005035924144aab201dce615b15 Author: Sebastien SG <sebsg@chromium.org> Date: Thu Jun 21 03:14:12 2018 [AF] Add CTR and save rate metrics split out by security level. This Cl adds autofill metrics based on the security level. The goal is to see whether the security level impacts the CTR of autofill suggestions or the card save rate. Bug: 853347 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I75ce8c6b924d7fd90e80e518af46509bb6bccde2 Reviewed-on: https://chromium-review.googlesource.com/1103218 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569136} [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/android_webview/browser/aw_autofill_client.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/android_webview/browser/aw_autofill_client.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/autofill_client.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/test_autofill_client.cc [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/components/autofill/core/browser/test_autofill_client.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/ios/chrome/browser/autofill/autofill_controller_unittest.mm [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/ios/web_view/internal/autofill/web_view_autofill_client_ios.h [modify] https://crrev.com/52104cbdba78f005035924144aab201dce615b15/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406 commit 515ab3c4b9c61090f4f4b3d76feed3c05f1cf406 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Jun 21 07:59:18 2018 Revert "[AF] Add CTR and save rate metrics split out by security level." This reverts commit 52104cbdba78f005035924144aab201dce615b15. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 569136 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUyMTA0Y2JkYmE3OGYwMDUwMzU5MjQxNDRhYWIyMDFkY2U2MTViMTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10528 Sample Failed Step: components_unittests Original change's description: > [AF] Add CTR and save rate metrics split out by security level. > > This Cl adds autofill metrics based on the security level. The > goal is to see whether the security level impacts the CTR of > autofill suggestions or the card save rate. > > Bug: 853347 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I75ce8c6b924d7fd90e80e518af46509bb6bccde2 > Reviewed-on: https://chromium-review.googlesource.com/1103218 > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569136} Change-Id: I16e9c57d18fbb81e37742bee5269816e7be377a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853347 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1109618 Cr-Commit-Position: refs/heads/master@{#569184} [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/android_webview/browser/aw_autofill_client.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/android_webview/browser/aw_autofill_client.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/autofill_client.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/test_autofill_client.cc [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/components/autofill/core/browser/test_autofill_client.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/ios/chrome/browser/autofill/autofill_controller_unittest.mm [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/ios/web_view/internal/autofill/web_view_autofill_client_ios.h [modify] https://crrev.com/515ab3c4b9c61090f4f4b3d76feed3c05f1cf406/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13e0e6f499d84ef9ad686302caaf7a318a11e31e commit 13e0e6f499d84ef9ad686302caaf7a318a11e31e Author: Sebastien SG <sebsg@chromium.org> Date: Thu Jun 21 20:03:12 2018 Re-[AF] Add CTR and save rate metrics split out by security level. Reland of crrev.com/c/1103218 with a one line change. This cl was reverted because the security_level in the autofill_metrics_unittests was not set explicitely. The first patch is the original CL. The second one sets the security level explicitely in the test class. Original Description: This Cl adds autofill metrics based on the security level. The goal is to see whether the security level impacts the CTR of autofill suggestions or the card save rate. Tbr: eugenebut@chromium.org, michaelbai@chromium.org, cthomp@chromium.org Bug: 853347 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ca3460921cf61f35f679013fa8a784c213fa35b Reviewed-on: https://chromium-review.googlesource.com/1110139 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569363} [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/android_webview/browser/aw_autofill_client.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/android_webview/browser/aw_autofill_client.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/autofill_client.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/test_autofill_client.cc [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/components/autofill/core/browser/test_autofill_client.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/ios/chrome/browser/autofill/autofill_controller_unittest.mm [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/ios/web_view/internal/autofill/web_view_autofill_client_ios.h [modify] https://crrev.com/13e0e6f499d84ef9ad686302caaf7a318a11e31e/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca9d9cda6c0abec676649d4b3b3aeb2d7a1adb61 commit ca9d9cda6c0abec676649d4b3b3aeb2d7a1adb61 Author: Christopher Thompson <cthomp@chromium.org> Date: Thu Jun 28 21:05:04 2018 Add histogram entries for autofill SecurityLevel metrics The previous CL (crrev.com/c/1103218) did not add the entries for the new histograms in histograms.xml (preventing them from getting collected by UMA). This CL makes a small change to the previous CL to simplify the histogram names (re-using the same base autofill histograms as already exist), and adds their suffixed histograms recursively to the set of affected histograms for the SecurityLevel suffix. These metrics are used for splitting some of the existing autofill histograms by the SecurityLevel of the page on which they occur (to be able to distinguish autofill behavior on different types of pages). This also adds two owners to the "SecurityLevel" suffix as it is now applied to histograms not already owned by Enamel folk. Bug: 853347 Change-Id: I9151b55a69e92353d17634b60aba5725e67d3c08 Reviewed-on: https://chromium-review.googlesource.com/1117740 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#571255} [modify] https://crrev.com/ca9d9cda6c0abec676649d4b3b3aeb2d7a1adb61/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/ca9d9cda6c0abec676649d4b3b3aeb2d7a1adb61/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/ca9d9cda6c0abec676649d4b3b3aeb2d7a1adb61/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/ca9d9cda6c0abec676649d4b3b3aeb2d7a1adb61/tools/metrics/histograms/histograms.xml
Comment 1 by dlkumar@google.com
, Jun 15 2018