New issue
Advanced search Search tips

Issue 853334 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

switch to 100% beta / stable experiment for MCVD

Project Member Reported by liber...@chromium.org, Jun 15 2018

Issue description

i'd like to switch MCVD in M68 from "on by default unless turned off by finch" to "off by default unless turned on by finch", along with a 100% beta / stable experiment.

the reason is webview: it ignores finch.  i'd like not to roll it out to webview until we've seen it succeed in stable, since we have an off switch in stable.  we can roll it out permanently in 69 for webview too.

CL is: https://chromium-review.googlesource.com/c/chromium/src/+/1103139
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 15 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by cmasso@google.com, Jun 18 2018

What feature is this part of? Sorry I missed the context here.
yeah, i should remember that folks can't read my mind.  sorry about that.

MCVD == MediaCodecVideoDecoder == mojo-based replacement for our existing android hardware video decoder (AVDA).  it was going to ship in 67 but i held it back due to a last-minute bug.

if it weren't for webview, then it could continue being on by default.  i just wouldn't have an off switch for webview then.

Comment 4 by cma...@chromium.org, Jun 18 2018

Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Makes sense. Approved.
Status: Fixed (was: Started)
thanks!  merged.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/347138e420c6dfd9e78cf772ad87e6abcbc42621

commit 347138e420c6dfd9e78cf772ad87e6abcbc42621
Author: liberato@chromium.org <liberato@chromium.org>
Date: Mon Jun 18 20:33:59 2018

Turn off MojoVideoDecoder for Android.

Bug:  853334 
Change-Id: I60e2e13be1ef21839e5e653e77acca62edebd8fb
Reviewed-on: https://chromium-review.googlesource.com/1103139
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#415}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/347138e420c6dfd9e78cf772ad87e6abcbc42621/media/base/media_switches.cc

Sign in to add a comment