Issue 853330 link

Starred by 5 users

Issue metadata

Status:	Fixed
Owner:	rohitrao@chromium.org
Closed:	Jul 27
Cc:	ios-bugs-priority@chromium.org ios-bugs@chromium.org
Components:	Infra>Client>iOS
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	1
Type:	Task
Q2 M-69 Proj-UIRefresh MS-Infrastructure UIRefresh-NoMerge

Bring up iOS bots with UIRefresh disabled

Project Member Reported by rohitrao@chromium.org, Jun 15 2018

Issue description

Until this feature ships, we should have bots running with the flag disabled.

A number of tests currently fail with the flag disabled, so those will need to be fixed first.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ec54e24c89454587c466d697df3885daf3d9d2

commit 36ec54e24c89454587c466d697df3885daf3d9d2
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Jun 15 21:05:46 2018

[ios] Fixes BubbleViewTest with the UIRefresh flag disabled.

BUG= 853330 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia30d658545ce7d3eb3397f1d1e282cbb7d581dc7
Reviewed-on: https://chromium-review.googlesource.com/1103117
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567789}
[modify] https://crrev.com/36ec54e24c89454587c466d697df3885daf3d9d2/ios/chrome/browser/ui/bubble/bubble_view_unittest.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c10bd4b7bfe57aa41b853a8dc15104c8a38c7fb4

commit c10bd4b7bfe57aa41b853a8dc15104c8a38c7fb4
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jun 18 16:06:27 2018

[ios] Fixes the implementation of [BookmarkTestCase scrollToTop].

This method was incorrectly invoking an EarlGrey method that scrolled to
the bottom of the view, not the top.

BUG= 853330 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic5bfe4be02594828c4c12a45e3dab78a51641cac
Reviewed-on: https://chromium-review.googlesource.com/1104382
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568020}
[modify] https://crrev.com/c10bd4b7bfe57aa41b853a8dc15104c8a38c7fb4/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0df394a7c00cde46436b407687b480f2e6d7c060

commit 0df394a7c00cde46436b407687b480f2e6d7c060
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jun 18 18:38:23 2018