New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853321 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 870105
Owner:
Last visit > 30 days ago
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fill in placeholder URL (chrome::kMultiDeviceLearnMoreURL)

Project Member Reported by jordynass@chromium.org, Jun 15 2018

Issue description

Placeholder URL will be replaced once the MultiDevice help page in chrome support is written and up.
 

Comment 1 by gov...@chromium.org, Jun 15 2018

Pls apply appropriate OSs label.

Comment 2 by gov...@chromium.org, Jun 18 2018

Pls apply appropriate OSs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 19 2018

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 22 2018

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Jun 26 2018

Pls apply appropriate OSs label. Thank you.
Pls apply appropriate OSs label. Thank you.
Pls apply appropriate OSs label. Thank you.
Pls apply appropriate OSs label.

Comment 9 Deleted

Labels: OS-Chrome
Has this been completed? Please update as this is RBS.
Status: Assigned (was: Untriaged)
Components: UI>ProximityAuth
Cc: zalcorn@chromium.org
P3 marked as a blocker? What is the justification, there has been no meaningful update since this was opened. Thanks.
Cc: jessejames@chromium.org
+jesse for smart unlock
Labels: -ReleaseBlock-Stable
This will be a quick fix but it does not need to block release.
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3460c477c3d47995fdc58a63c3886c398cfcf058

commit 3460c477c3d47995fdc58a63c3886c398cfcf058
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Sep 05 19:54:07 2018

[CrOS MultiDevice] Fill Placeholder learn more links for suite/messages

The placeholders were complete dummy links before this CL. Although the
info page for the Better Together (a.k.a. MultiDevice) suite is not yet
fully build, we are filling it in the like we plan to use for eve in
the meantime.

Bug:  853321 
Change-Id: I9bcfc4693455b3d7083cc6f3bb4ff4474c787bfb
Reviewed-on: https://chromium-review.googlesource.com/1208350
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588975}
[modify] https://crrev.com/3460c477c3d47995fdc58a63c3886c398cfcf058/chrome/common/url_constants.cc

Status: Started (was: Assigned)
Mergedinto: 870105
Status: Duplicate (was: Started)
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 7

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ed23a23037a676d10ec4eb3f1991a15f54553e

commit e2ed23a23037a676d10ec4eb3f1991a15f54553e
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Fri Sep 07 02:24:39 2018

[CrOS MultiDevice] Fill Placeholder learn more links for suite/messages

The placeholders were complete dummy links before this CL. Although the
info page for the Better Together (a.k.a. MultiDevice) suite is not yet
fully build, we are filling it in the like we plan to use for eve in
the meantime.

Bug:  853321 
Change-Id: I9bcfc4693455b3d7083cc6f3bb4ff4474c787bfb
Reviewed-on: https://chromium-review.googlesource.com/1208350
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588975}(cherry picked from commit 3460c477c3d47995fdc58a63c3886c398cfcf058)
Reviewed-on: https://chromium-review.googlesource.com/1212350
Cr-Commit-Position: refs/branch-heads/3538@{#124}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e2ed23a23037a676d10ec4eb3f1991a15f54553e/chrome/common/url_constants.cc

Labels: CommitLog-Audit-Violation Merge-Without-Approval M-70
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision e2ed23a23037a676d10ec4eb3f1991a15f54553e was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
This was merged because the canonical dupe bug (870105) was actually already approved.

Sign in to add a comment