Currently when sync_submodules constructs the .gitmodules file, it adds an item called 'os', which is a list of keys coming from the deps_os section, or 'all'.  Example: [1]

I don't know why it does this.  AFAIK Git doesn't recognize this, so WTF?  Anyway, gclient revinfo does not pass this information through; so we will not be able to include it.

I think this is fine; but please LMK if you disagree.

1. https://chromium.googlesource.com/chromium/tools/build/codesearch/+/master/.gitmodules#32

 Issue 818798  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cf6a6f1c1fef878ed855d79019a9c1ca794ab350

commit cf6a6f1c1fef878ed855d79019a9c1ca794ab350
Author: Alan Bram <flyboy@chromium.org>
Date: Tue Jun 26 20:46:40 2018

Use bot_update and gclient revinfo for Code Search sync submodules.

More robust than doing its own DEPS file parsing.

Bug: 853312
Change-Id: I3d517c33220681867d2c608b1726b06a1f9159c8
Reviewed-on: https://chromium-review.googlesource.com/1104963
Commit-Queue: Alan Bram <flyboy@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.py
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/basic_with_prefix.json
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipe_modules/sync_submodules/api.py
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipe_modules/sync_submodules/__init__.py
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/basic_with_diff.json
[delete] https://crrev.com/2dce15bb535d7588dc614cd4b2aa4e02ba90e3d7/recipes/recipe_modules/sync_submodules/resources/deps_utils.py
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/README.recipes.md
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/basic_experimental.json
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipe_modules/sync_submodules/resources/deps2submodules.py
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/with_one_extra_submodule.json
[delete] https://crrev.com/2dce15bb535d7588dc614cd4b2aa4e02ba90e3d7/recipes/recipes/sync_submodules.expected/basic_with_recurse_deps.json
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/basic_with_diff_failure.json
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/basic.json
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/with_two_extra_submodules.json
[modify] https://crrev.com/cf6a6f1c1fef878ed855d79019a9c1ca794ab350/recipes/recipes/sync_submodules.expected/basic_with_prefix_disabled.json

 Issue 849415  has been merged into this issue.