New issue
Advanced search Search tips

Issue 853311 link

Starred by 3 users
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: Jun 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Resize incognito text when Dynamic Type settings change

Project Member Reported by rohitrao@chromium.org, Jun 15 2018 
The incognito title uses adjustsFontForContentSizeCategory=YES and therefore responds automatically to dynamic type changes, but the bulleted lists use NSAttributedStrings with baked-in fonts.  We should register for the category changed notification and use it to redisplay the bulleted lists.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e6bbcce7faf8c6c3cc701509672bdcdf95e1700

commit 2e6bbcce7faf8c6c3cc701509672bdcdf95e1700
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Jun 15 23:17:26 2018

[ios] Updates IncognitoView to redisplay on Dynamic Type changes.

BUG= 853311 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I52c732677d85ad0d102a9868eff3107e75dad3e0
Reviewed-on: https://chromium-review.googlesource.com/1103017
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567825}
[modify] https://crrev.com/2e6bbcce7faf8c6c3cc701509672bdcdf95e1700/ios/chrome/browser/ui/ntp/incognito_view.mm

Comment 2 by rohitrao@chromium.org, Jun 16 2018

Status: Fixed (was: Started)
►

Sign in to add a comment