MacViews: CaptivePortalBrowserTest.GoBack failing under unified compositing |
|||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/73242 for example [83927:775:0615/111149.896546:FATAL:browser_compositor_view_mac.mm(611)] Check failed: !parent_ui_layer_. We're theorizing that maybe a layer is being leaked?
,
Jun 19 2018
,
Jun 19 2018
I think it's a real issue -- hoping to be able to reproduce it locally. If this is the only thing blocking flip-switching, then just disable it and I'll re-enable when it's working.
,
Jun 19 2018
Actually, no need to disable -- fix is up for review.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acd68e8c00229ff395a8a4852a1cf3aa0d5f9f77 commit acd68e8c00229ff395a8a4852a1cf3aa0d5f9f77 Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Jun 20 03:48:03 2018 MacViews: Fix DCHECK in CaptivePortalBrowserTest.GoBack Allow BrowserCompositorMac to transition between different parent UI layers, if needed. Bug: 853302 Change-Id: I85596a1fe42c490d770f023c68d9a4093f050dcc Reviewed-on: https://chromium-review.googlesource.com/1107047 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568716} [modify] https://crrev.com/acd68e8c00229ff395a8a4852a1cf3aa0d5f9f77/content/browser/renderer_host/browser_compositor_view_mac.h [modify] https://crrev.com/acd68e8c00229ff395a8a4852a1cf3aa0d5f9f77/content/browser/renderer_host/browser_compositor_view_mac.mm
,
Jun 20 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by robliao@chromium.org
, Jun 19 2018