New issue
Advanced search Search tips

Issue 853295 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 497851



Sign in to add a comment

[css-scroll-snap] Attach SnapContainerData directly to ScrollableArea

Project Member Reported by szager@chromium.org, Jun 15 2018

Issue description

Rather than keeping SnapContainerData for all scrollers in a SnapCoordinator attached to the document, it makes more sense to just associate SnapContainerData directly with its ScrollableArea.

For PaintLayerScrollableArea, there is already a PaintLayerScrollableAreaRareData class, which is the obvious place for this.

For RootFrameViewport, it's probably OK to just add it to that class directly.
 
Rather than keeping SnapContainerData for all scrollers in a SnapCoordinator attached to the document, it makes more sense to just associate SnapContainerData directly with its ScrollableArea.

For PaintLayerScrollableArea, there is already a PaintLayerScrollableAreaRareData class, which is the obvious place for this.

For RootFrameViewport, it's probably OK to just add it to that class directly.

Comment 2 by bokan@chromium.org, Jun 21 2018

Owner: majidvp@chromium.org
Status: Assigned (was: Untriaged)
Majid, please triage.
I believe szager@ is planning to do this after M69 branch which is when we plan to ship snap points.
Owner: szager@chromium.org
Assigning to szager@ who wanted to land this as a clean up. M69 is branched so it is safe to do this now.

Sign in to add a comment