New issue
Advanced search Search tips

Issue 853289 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

InternalOnlyModel should raise InternalOnlyError instead of AssertionError

Project Member Reported by benjhayden@chromium.org, Jun 15 2018

Issue description

This exception is used by callers for control flow, so it should be a custom exception type, not AssertionError.
https://chromium.googlesource.com/catapult/+/master/dashboard/dashboard/models/internal_only_model.py#26
Fixing this will require auditing all code that transitively calls InternalOnlyModel.get[_async](), which is probably quite a lot of code.
This might be easier to fix after V2SPA launches and replaces most of the request handlers with new api request handlers, which should be less code that is clearer.
 
Cc: eakuefner@chromium.org
+1
Cc: -eakuefner@chromium.org

Sign in to add a comment