New issue
Advanced search Search tips

Issue 853281 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 489354
issue 642010

Blocking:
issue 853285



Sign in to add a comment

Supporting platform fonts in Android

Project Member Reported by yus...@chromium.org, Jun 15 2018

Issue description

Right now Android with the exception of VR is using platform_font_android for Font support, which is actually NOTIMPLEMENTED. platform_font_linux does work and can be used for rendering Android platform fonts as well, similar to what we do for VR in ui/gfx/BUILD.gn

We should make the VR specific build setup the default for Android, so that we can use RenderText from drawing in compositor UI

 

Comment 1 by yus...@chromium.org, Jun 15 2018

Blocking: 853285

Comment 2 by yus...@chromium.org, Jun 28 2018

Cc: yus...@chromium.org
Owner: wychen@chromium.org
Assigning to wychen.

Ideally we should just remove platform_font_android all together and have us use platform_font_linux everywhere, VR or non-VR.
Status: Started (was: Assigned)
Cc: asvitk...@chromium.org
asvitkine@, what do you think about removing platform_font_android and using platform_font_linux in Clank, VR or non-VR?

This allows us to directly render text in compositor UI instead of rendering to a bitmap first.
No objections from my side. I think the history is originally Android didn't need that code and so mostly stubbed it out - but if it's now useful, seems reasonable to use the linux impl.
Blockedon: 489354 642010
Thanks. Before actually using the Linux impl on Android, I'd like to enable as many tests as possible on Android first, to be sure this is reliable.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db6633b3ee5a565b4b610a1509c99b23209cb7d5

commit db6633b3ee5a565b4b610a1509c99b23209cb7d5
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Mon Jul 23 23:38:35 2018

Use Linux fonts impl on Android

Right now Android build uses platform_font_linux if the VR
support is enabled. VR support is enabled on all Android ARM
builds (see |enable_gvr_services| and crbug/733935).

We'd like to use RenderText in compositor UI, so this CL
makes all Android builds use platform_font_linux, regardless
of whether VR is enabled.

This only affects non-ARM Android builds.

Bug:  853281 ,  642010 
Change-Id: I843c53964f1af932ad9f00b67ac690c5b43916ab
Reviewed-on: https://chromium-review.googlesource.com/1142484
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577324}
[modify] https://crrev.com/db6633b3ee5a565b4b610a1509c99b23209cb7d5/ui/gfx/BUILD.gn
[delete] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gfx/canvas_notimplemented.cc
[modify] https://crrev.com/db6633b3ee5a565b4b610a1509c99b23209cb7d5/ui/gfx/font_render_params.h
[delete] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gfx/platform_font_android.cc
[delete] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gfx/text_utils_android.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6cd98df116e9945e90dd347b2a55bdb236ccd78

commit f6cd98df116e9945e90dd347b2a55bdb236ccd78
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 24 00:12:14 2018

Enable font-related unit tests on Android

FontListTest::Fonts_GetHeight_GetBaseline is still disabled
because I couldn't find two fonts with different baseline and
different height on Android.

This depends on crrev.com/c/1142484 for non-ARM build.

Bug:  853281 ,  489354 ,  642010 
Change-Id: Iacf6124794ee53f5f9e30f59bdd958f3883c7ea2
Reviewed-on: https://chromium-review.googlesource.com/1141175
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577359}
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/canvas_unittest.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/font_list_unittest.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/font_names_testing.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/font_unittest.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/text_utils_unittest.cc

Blockedon: 866720
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22100358580bd5386491478e2fb72d1ccee1d0b8

commit 22100358580bd5386491478e2fb72d1ccee1d0b8
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 24 02:21:50 2018

Enable render_text_unittest on Android

Some tests are disabled for now.

Bug:  853281 , 865527,  865540 , 865709, 865715
Change-Id: I4fda286ff877301704426820ee10d200cd54468b
Reviewed-on: https://chromium-review.googlesource.com/1144305
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577408}
[modify] https://crrev.com/22100358580bd5386491478e2fb72d1ccee1d0b8/ui/gfx/BUILD.gn
[modify] https://crrev.com/22100358580bd5386491478e2fb72d1ccee1d0b8/ui/gfx/render_text_unittest.cc

Blockedon: -866720
Status: Fixed (was: Started)

Sign in to add a comment