New issue
Advanced search Search tips

Issue 853277 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-login unit test failing on R68 branch

Project Member Reported by manojgupta@chromium.org, Jun 15 2018

Issue description

https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-release%20release-R68-10718.B/builds/20

chromeos-login-0.0.2-r3687: [1/2] CXX obj/login_manager/session_manager_test.session_manager_impl_unittest.o
chromeos-login-0.0.2-r3687: FAILED: obj/login_manager/session_manager_test.session_manager_impl_unittest.o 
chromeos-login-0.0.2-r3687: x86_64-cros-linux-gnu-clang++ -MMD -MF obj/login_manager/session_manager_test.session_manager_impl_unittest.o.d -DOS_CHROMEOS -DUSE_CHEETS=1 -DUSE_NSS_CERTS -DUSE_SYSTEMD=0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DUNIT_TEST -Iobj/login_manager/session_manager_test.gen/include -Igen/include -I/mnt/host/source/src/platform2 -I/mnt/host/source/src/platform -I/build/samus/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/samus -DUSE_RTTI_FOR_TYPE_TAGS -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/samus/usr/include/chromeos -I/build/samus/usr/include/base-395517 -I/build/samus/usr/include/glib-2.0 -I/build/samus/usr/lib64/glib-2.0/include -I/build/samus/usr/include/nss -I/build/samus/usr/include/nspr -I/build/samus/usr/include/chromeos -I/build/samus/usr/include/base-test-395517 -I/build/samus/usr/include/dbus-1.0 -I/build/samus/usr/lib64/dbus-1.0/include -fPIE -std=gnu++14 -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc -o obj/login_manager/session_manager_test.session_manager_impl_unittest.o
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:2118:76: error: too few arguments to function call, expected 8, have 7
chromeos-login-0.0.2-r3687:               "en_US" /* locale */, std::string() /* preferred_languages */),
chromeos-login-0.0.2-r3687:                                                                            ^
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1845:61: note: expanded from macro 'EXPECT_CALL'
chromeos-login-0.0.2-r3687: #define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
chromeos-login-0.0.2-r3687:                                                             ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1844:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
chromeos-login-0.0.2-r3687:     ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
chromeos-login-0.0.2-r3687:                    ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:684:3: note: 'GetUpgradeContainerExpectations' declared here
chromeos-login-0.0.2-r3687:   std::vector<std::string> GetUpgradeContainerExpectations(
chromeos-login-0.0.2-r3687:   ^
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:2214:54: error: too few arguments to function call, expected 8, have 7
chromeos-login-0.0.2-r3687:               std::string() /* preferred_languages */),
chromeos-login-0.0.2-r3687:                                                      ^
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1845:61: note: expanded from macro 'EXPECT_CALL'
chromeos-login-0.0.2-r3687: #define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
chromeos-login-0.0.2-r3687:                                                             ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1844:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
chromeos-login-0.0.2-r3687:     ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
chromeos-login-0.0.2-r3687:                    ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:684:3: note: 'GetUpgradeContainerExpectations' declared here
chromeos-login-0.0.2-r3687:   std::vector<std::string> GetUpgradeContainerExpectations(
chromeos-login-0.0.2-r3687:   ^
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:2337:76: error: too few arguments to function call, expected 8, have 7
chromeos-login-0.0.2-r3687:               "en_US" /* locale */, std::string() /* preferred_languages */),
chromeos-login-0.0.2-r3687:                                                                            ^
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1845:61: note: expanded from macro 'EXPECT_CALL'
chromeos-login-0.0.2-r3687: #define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
chromeos-login-0.0.2-r3687:                                                             ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1844:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
chromeos-login-0.0.2-r3687:     ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
chromeos-login-0.0.2-r3687:                    ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:684:3: note: 'GetUpgradeContainerExpectations' declared here
chromeos-login-0.0.2-r3687:   std::vector<std::string> GetUpgradeContainerExpectations(
chromeos-login-0.0.2-r3687:   ^
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:2634:76: error: too few arguments to function call, expected 8, have 7
chromeos-login-0.0.2-r3687:               "en_US" /* locale */, std::string() /* preferred_languages */),
chromeos-login-0.0.2-r3687:                                                                            ^
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1845:61: note: expanded from macro 'EXPECT_CALL'
chromeos-login-0.0.2-r3687: #define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
chromeos-login-0.0.2-r3687:                                                             ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1844:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
chromeos-login-0.0.2-r3687:     ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
chromeos-login-0.0.2-r3687:                    ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:684:3: note: 'GetUpgradeContainerExpectations' declared here
chromeos-login-0.0.2-r3687:   std::vector<std::string> GetUpgradeContainerExpectations(
chromeos-login-0.0.2-r3687:   ^
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:2682:76: error: too few arguments to function call, expected 8, have 7
chromeos-login-0.0.2-r3687:               "en_US" /* locale */, std::string() /* preferred_languages */),
chromeos-login-0.0.2-r3687:                                                                            ^
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1845:61: note: expanded from macro 'EXPECT_CALL'
chromeos-login-0.0.2-r3687: #define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
chromeos-login-0.0.2-r3687:                                                             ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../usr/include/gmock/gmock-spec-builders.h:1844:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
chromeos-login-0.0.2-r3687:     ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
chromeos-login-0.0.2-r3687:                    ^~~~
chromeos-login-0.0.2-r3687: ../../../../../../../../../mnt/host/source/src/platform2/login_manager/session_manager_impl_unittest.cc:684:3: note: 'GetUpgradeContainerExpectations' declared here
chromeos-login-0.0.2-r3687:   std::vector<std::string> GetUpgradeContainerExpectations(
chromeos-login-0.0.2-r3687:   ^
chromeos-login-0.0.2-r3687: 5 errors generated.
chromeos-login-0.0.2-r3687: ninja: build stopped: subcommand failed.
 

Comment 1 by derat@chromium.org, Jun 15 2018

Owner: derat@chromium.org
Status: Started (was: Untriaged)
Looks like a bad merge in 99b01956ac8498b3761ca5f615fdd552e322fbb2 (https://crrev.com/c/1099481). I think that Yury is in a different time zone right now, so I'll upload a quick fix.

Comment 2 by derat@chromium.org, Jun 15 2018

Cc: khmel@chromium.org yusukes@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2018

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/de880bcc35ebb4f48933f81d03e8d3520ded66ad

commit de880bcc35ebb4f48933f81d03e8d3520ded66ad
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jun 15 20:12:07 2018

login: Fix session_manager_impl_unittest.cc merge.

Fix a merge error in 99b01956ac84 that results in
compilation errors about a missing demo_session_apps_path
argument in calls to GetUpgradeContainerExpectations method.
To fix tests, also make the method not return
SUPERVISION_TRANSITION (added by 8560afcc78da, which isn't
going to be merged to M68).

BUG= chromium:853277 
TEST=emerged with FEATURES=test

Change-Id: Ic1b5d9867882994edb394be7011d531cde054802
Reviewed-on: https://chromium-review.googlesource.com/1103059
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Trybot-Ready: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/de880bcc35ebb4f48933f81d03e8d3520ded66ad/login_manager/session_manager_impl_unittest.cc

Comment 4 by derat@chromium.org, Jun 15 2018

Status: Fixed (was: Started)

Sign in to add a comment