New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853269 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Do not reset content position or size when recentering

Project Member Reported by vollick@chromium.org, Jun 15 2018

Issue description

Otherwise recentering to fix minor alignment problems can upset the content positioning.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be17bc5665a2b0c7308b49ca4eeb7241fedaf7e

commit 6be17bc5665a2b0c7308b49ca4eeb7241fedaf7e
Author: Ian Vollick <vollick@chromium.org>
Date: Fri Jun 15 19:11:59 2018

[vr] Do not reset content position or size when recentering

This allows minor alignment adjustments via recentering without
affecting the location or size of the content quad.

Bug:  853269 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3de1b8b727b9c50f60e3dfd791a7a991930f3012
Reviewed-on: https://chromium-review.googlesource.com/1102877
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567757}
[modify] https://crrev.com/6be17bc5665a2b0c7308b49ca4eeb7241fedaf7e/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/6be17bc5665a2b0c7308b49ca4eeb7241fedaf7e/chrome/browser/vr/ui_unittest.cc

Labels: M-68 Merge-Request-68
I've confirmed the fix on Canary. The change is quite low risk (I've just disconnected the recentering code).
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 18 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cmasso@google.com, Jun 18 2018

Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c63a804d7b63a76b8df3309726b5539d220f93

commit 43c63a804d7b63a76b8df3309726b5539d220f93
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jun 18 17:52:07 2018

[vr] Do not reset content position or size when recentering

This allows minor alignment adjustments via recentering without
affecting the location or size of the content quad.

Bug:  853269 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3de1b8b727b9c50f60e3dfd791a7a991930f3012
Reviewed-on: https://chromium-review.googlesource.com/1102877
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567757}(cherry picked from commit 6be17bc5665a2b0c7308b49ca4eeb7241fedaf7e)
Reviewed-on: https://chromium-review.googlesource.com/1104818
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#399}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/43c63a804d7b63a76b8df3309726b5539d220f93/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/43c63a804d7b63a76b8df3309726b5539d220f93/chrome/browser/vr/ui_unittest.cc

Status: Fixed (was: Started)
Verified in Chrome Beta 68.0.3440.39
Status: Verified (was: Fixed)

Sign in to add a comment