Create appropriate accessibility text for omnibox rich entity suggestions |
|||||||||
Issue descriptionThis is set up in AutocompleteMatchType::ToAccessibilityLabel: https://cs.chromium.org/chromium/src/components/omnibox/browser/autocomplete_match_type.cc?l=62&rcl=f27798f4413b6f5e01b3c07aba49b9717e3b0cee The SEARCH_SUGGEST_ENTITY type needs to get its own label as the general search one is only reading out the query text (e.g. "Daisy Ridley") and isn't including the entity type (e.g. "Actress"). I also got a report that it the accessibility text was including something for the image. Looking at the code real quick, I don't see that but if it is, the guidance was that there should be no associated text for the images in rich entity suggestions. Send the review to aleventhal@ and jdonnelly@.
,
Jun 18 2018
,
Jun 22 2018
I started looking at this yesterday but haven't been able to get entity suggestions to work at all, despite setting various combinations of flags. My setup may be special, though, as I'm also getting Aw Snap crashes deep in blink just for pushing a back button from chrome://settings/manageProfile Once I get entities working, though, I'll see if I can make sense of this bug.
,
Jun 28 2018
,
Jun 29 2018
,
Jun 29 2018
Sent the below email a couple days ago but aleventhal@ may be busy, so anyone knowledgeable about accessibility, feel free to step in and describe what we would like to read out for the user... personally, my take is that the brief search suggestion is already the right thing to be reading out, but I am not versed enough in entities or accessibility use cases to make an informed decision at this point. In other words, tell me what it should do and I will code it. Maybe something like:
<message name="IDS_ACC_AUTOCOMPLETE_SUGGESTED_ENTITY" desc="Text for screenreaders describing a suggested entity.">
<ph name="TEXT">$1<ex>Muhammad Ali</ex> $2<ex>American professional boxer</ex> entity suggestion</ph>
</message>
But this reads out "Muhammad Ali American professional boxer entity suggestion" and I think that's way more wordy and confusing than the current "Muhammad Ali search suggestion".
"""
Hi Aaron, I am working on crbug.com/853252 and am looking for a bit of guidance about how to produce the accessibility label for rich entity suggestions. Currently, entity suggestions produce an accessibility label with the search query + " search suggestion". But usually there is also an entity type/description, and the goal of the bug is to include this information.
Here's an example of what's being used today: Typing "Muha" results in an entity suggestion for Muhammad Ali (search query), an American professional boxer (entity type/description). The accessibility label is "Muhammad Ali search suggestion". Is that already ideal, for being brief and to the point, or should we read out all information available? What new message should we use to include the description? Ideally it would be flexible enough to handle entities with and without descriptions. Diana, Princess of Wales doesn't seem to have a description, e.g.
<message name="IDS_ACC_AUTOCOMPLETE_SUGGESTED_SEARCH" desc="Text for screenreaders describing a suggested search.">
<ph name="TEXT">$1<ex>dogs</ex> search suggestion</ph>
</message>
"""
,
Jun 29 2018
My two cents: "entity" sounds like a technical term. I'd avoid it. I'd rather hear something like "Muhammad Ali, the American professional boxer, search suggestion" I say this as someone who has the privilege of never needing to use this accessibility feature of Chrome...
,
Jun 30 2018
Okay, thanks, I will give it a go and see how it works for various entities.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b637620bcac24a5259e944d81834050e055524c1 commit b637620bcac24a5259e944d81834050e055524c1 Author: Orin Jaworski <orinj@chromium.org> Date: Tue Jul 03 20:33:18 2018 [omnibox] Add accessibility text for rich entity suggestions Rich entity search suggestions with description will use a new accessibility label format including the entity name, followed by the description, followed by "search suggestion". Entities without a description will fall back to the simple search suggestion format as before. Bug: 853252 Change-Id: I978ceafc07971704d7fcf0ad3d2e27e5f3ec7763 Reviewed-on: https://chromium-review.googlesource.com/1123158 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#572342} [modify] https://crrev.com/b637620bcac24a5259e944d81834050e055524c1/components/omnibox/browser/autocomplete_match_type.cc [modify] https://crrev.com/b637620bcac24a5259e944d81834050e055524c1/components/omnibox_strings.grdp
,
Jul 11
aleventhal: can you verify that this is working effectively now?
I tried testing it with Narrator on Windows but this doesn't seem to work with the omnibox? All it did as I navigated the suggestion list was echo the key I had pressed ("tab", "down arrow", "space", etc.)
,
Jul 12
,
Jul 13
Yes, this is working well for me with NVDA2018.2.1. It is a bit confusing because I am not sure what will be searched for. With experimentation, I found the search text is everything before the comma. We might think about changing the separator char to ':' and/or putting the additional info in parenthesis.
,
Jul 13
That's an idea - might make things more clear structurally. The reason for the commas was to introduce a brief pause in the screen-reader output, giving all the information but without delays for extra punctuation or delimiting words.
,
Jul 13
Reducing priority to P3 for potential follow-on improvements.
,
Sep 20
,
Sep 26
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jdonnelly@chromium.org
, Jun 18 2018