New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853225 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Need to Reenable Auto-Revert

Project Member Reported by robliao@chromium.org, Jun 15 2018

Issue description

Sheriffs can disable autorevert but can't reenable it?

https://findit-for-me.appspot.com/waterfall/change-auto-revert-setting

 

Comment 1 by st...@chromium.org, Jun 15 2018

We intentionally make it that way. Because disabling auto-revert means that something is really wrong, and Findit folks need to be involved to resolve that and we will take care of reenabling auto-revert after the fire is off.

Mind sharing a little bit more about why auto-revert was turned off?
We wanted to experiment with a change and autorevert reverted the change before we could run the experiment.

Comment 3 by st...@chromium.org, Jun 15 2018

Components: -Infra
Owner: chanli@chromium.org
Status: Assigned (was: Untriaged)
I found it: Suspected victim https://chromium-review.googlesource.com/c/chromium/src/+/1101763 of http://crbug.com/853069 was likely incorrectly reverted

I will look into this before Findit's oncall is in office.

Comment 4 by st...@chromium.org, Jun 15 2018

For this case, you may follow this to disable autorevert just for that specific CL:

Developers: If you don't want Findit to auto-revert your change, please add a flag 'NOAUTOREVERT=true' in your CL description. Example https://chromium-review.googlesource.com/c/chromium/src/+/744731

Comment 5 by st...@chromium.org, Jun 15 2018

Autorevert was enabled. chanli@ could follow up further if needed.
Status: Fixed (was: Assigned)

Sign in to add a comment