New issue
Advanced search Search tips

Issue 853219 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Scale interstitial text with video player size.

Project Member Reported by apaci...@chromium.org, Jun 15 2018

Issue description

For smaller video sizes, the interstitial text doesn't scale well.

Demo page: https://beaufortfrancois.github.io/sandbox/media/overflow-video.html

Spec: follow the modern controls. (ping apacible offline for deck)
 
unnamed.png
22.9 KB View Download
Components: Blink>Media>PictureInPicture
Labels: M-69
Status: Assigned (was: Untriaged)
Labels: OS-Linux
Owner: beccahughes@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5

commit 0a0ead8322055d8e8b449c4d088d81e4e35e6fa5
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Jul 27 22:51:31 2018

[Picture in Picture] Scale interstitial text

Scale interstitial text with the video player size based
on the modern controls spec. This uses a ResizeObserver
to add a CSS sizing class to the PiP interstitial.

This also contains a refactor to move the sizing calc
to MediaControls so we can use the same sizing logic
across Modern Media Controls and the PiP
interstitial.

BUG= 853219 

Change-Id: I46f7512e1a5fb8dc0c1a99e39af1a0d49756854c
Reviewed-on: https://chromium-review.googlesource.com/1138977
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578841}
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/WebKit/LayoutTests/media/picture-in-picture/picture-in-picture-interstitial-sizing.html
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/WebKit/LayoutTests/media/picture-in-picture/utils.js
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/blink/renderer/core/html/media/media_controls.cc
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/blink/renderer/core/html/media/media_controls.h
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.h
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/0a0ead8322055d8e8b449c4d088d81e4e35e6fa5/third_party/blink/renderer/modules/media_controls/resources/mediaInterstitials.css

Labels: Merge-Request-69
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 28

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please merge your change to M69 branch 3497 by 2:00 PM PT Monday, 07/30, so we can pick it up for next week last M69 Dev release. Thank you.

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40afbb345c18f96968815d2c74d3951374711f93

commit 40afbb345c18f96968815d2c74d3951374711f93
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jul 30 16:14:06 2018

[Picture in Picture] Scale interstitial text

Scale interstitial text with the video player size based
on the modern controls spec. This uses a ResizeObserver
to add a CSS sizing class to the PiP interstitial.

This also contains a refactor to move the sizing calc
to MediaControls so we can use the same sizing logic
across Modern Media Controls and the PiP
interstitial.

BUG= 853219 

Change-Id: I46f7512e1a5fb8dc0c1a99e39af1a0d49756854c
Reviewed-on: https://chromium-review.googlesource.com/1138977
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578841}(cherry picked from commit 0a0ead8322055d8e8b449c4d088d81e4e35e6fa5)
Reviewed-on: https://chromium-review.googlesource.com/1155071
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#211}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/WebKit/LayoutTests/media/picture-in-picture/picture-in-picture-interstitial-sizing.html
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/WebKit/LayoutTests/media/picture-in-picture/utils.js
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/blink/renderer/core/html/media/media_controls.cc
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/blink/renderer/core/html/media/media_controls.h
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.h
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/40afbb345c18f96968815d2c74d3951374711f93/third_party/blink/renderer/modules/media_controls/resources/mediaInterstitials.css

Status: Fixed (was: Started)

Sign in to add a comment