This one looks like a hard failure going to try and kick off a bisect.

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/107d15b9240000

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/107d15b9240000

Fix UseSurfaceLayerForVideo GPU crash handling. by kylechar@chromium.org
https://chromium.googlesource.com/chromium/src/+/f77f6b8dba2776e23111c84c5d9333dbb03039fe
0 → 1 (+1)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

I have no idea what's going on here. I don't think Android WebView uses the UseSurfaceLayerForVideo feature. WebView isn't setup to allow arbitrary embedding of CompositorFrameSinks. That CL made a change in VideoFrameSubmitter, which is only used with UseSurfaceLayerForVideo, so it shouldn't be crashing in a WebView perf test.

+mlamouri/lethalantidote could UseSurfaceLayerForVideo be turned on for Android WebView somehow?

 Issue 853190  has been merged into this issue.

Of note that this also caused a few regressions in WebView:
https://chromeperf.appspot.com/group_report?bug_id=853004

 Issue 853752  has been merged into this issue.

I believe that UseSurfaceLayerForVideo is enabled for Android WebView which won't work. I filed crbug.com/853832 for that issue.

I could revert the CL but I don't know if that's useful. The test wasn't crashing before but I don't think it was actually playing video. If you look at the last passing CL from the pinpoint run the async trace event for "playing" has no endpoint. Also testing webview_instrumentation_apk with my patch reverted and UseSurfaceLayerForVideo enabled the video is just black.

 Issue 853763  has been merged into this issue.

There were at least three CLs that disabled tests for the crash. It looks like the underlying issue got fixed in crbug.com/853832. Should I just remove the added lines in tools/perf/expectations.config?

https://chromium.googlesource.com/chromium/src.git/+/09ea71706118115f544c30f764eac24505a1ff9a
https://chromium.googlesource.com/chromium/src.git/+/f6842afd835db8620f5110da291afd6424c9b308
https://chromium.googlesource.com/chromium/src.git/+/a95dc41ca362d2578891dd81c7c9b1813bb4626a

Yes, please do! Thanks!

Thanks for digging into this! There was one crash that might not be related in the same CL range. I split it into  bug 854683 , bisect pending.

This CL also needs to get reverted.

https://chromium.googlesource.com/chromium/src.git/+/3948b2b2b423f1463ef2d126e842dc88f76e9459

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ae4fa78ccd21cf34c8861424bcfd87f4f2a538

commit 65ae4fa78ccd21cf34c8861424bcfd87f4f2a538
Author: kylechar <kylechar@chromium.org>
Date: Thu Jun 21 16:08:50 2018

Enable Android WebView perf tests.

Android WebView had the UseSurfaceLayerForVideo feature enabled
unintentionally which was causing a crash. This was fixed in
https://crbug.com/853832. Enable WebView perf tests that got disabled
due to the crash.

Bug:  853204 
Change-Id: Ib678a48ec723f40a4ab3be72f6078cafcfc311c6
Reviewed-on: https://chromium-review.googlesource.com/1110018
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569284}
[modify] https://crrev.com/65ae4fa78ccd21cf34c8861424bcfd87f4f2a538/tools/perf/expectations.config